Skip to content

Validate provider IDs#221

Merged
felixarntz merged 2 commits intotrunkfrom
provider-id-validation
Mar 18, 2026
Merged

Validate provider IDs#221
felixarntz merged 2 commits intotrunkfrom
provider-id-validation

Conversation

@felixarntz
Copy link
Member

Only allow lower-case alphanumeric characters, hyphens, and underscores.

@felixarntz felixarntz added this to the 1.3.1 milestone Mar 18, 2026
@felixarntz felixarntz added the [Type] Bug An existing feature does not function as intended label Mar 18, 2026
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick follow up 👍🏻

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (2d6efec) to head (77578a8).
⚠️ Report is 3 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #221      +/-   ##
============================================
+ Coverage     88.11%   88.12%   +0.01%     
- Complexity     1212     1213       +1     
============================================
  Files            60       60              
  Lines          3928     3934       +6     
============================================
+ Hits           3461     3467       +6     
  Misses          467      467              
Flag Coverage Δ
unit 88.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixarntz felixarntz merged commit fcf479f into trunk Mar 18, 2026
7 checks passed
@felixarntz felixarntz deleted the provider-id-validation branch March 18, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants