react-dom vendor script: remove __esModule flag#76925
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -243 B (0%) Total Size: 7.73 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 86de522. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23794546662
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #76825 that fixes an issue reported in #76825 (comment) by @enricobattocchi.
The
react-domscript has an unwanted__esModuleflag. Some consumers expect such a module to have adefaultfield, but our script doesn't have one. The entire module object is the default object, the CommonJS way.This PR fixes that by converting the "synthetic" module to CommonJS. The original React modules are also all CJS.
How to test:
Load Gutenberg and look at
window.ReactDOM. Before this patch, the object has an__esModulefield. After this patch, the field is no longer there.