WIP Use package.json React version for vendor script cache busting#76798
Closed
WIP Use package.json React version for vendor script cache busting#76798
Conversation
- Extend wp-build generated constants.php with react_version from root package.json (devDependencies or dependencies react field). - Define GUTENBERG_REACT_VENDOR_VERSION in load.php when present. - Pass that version to react, react-dom, and react-jsx-runtime registration; fall back to major "18" for older builds or projects without a react pin. Follow-up to the approach in #46768, tying ?ver= to the actual bundled React. Made-with: Cursor
ramonjd
commented
Mar 25, 2026
| gutenberg_url( 'build/scripts/vendors/react-dom' . $extension ), | ||
| array( 'react' ), | ||
| '18' | ||
| $react_vendor_version |
|
Size Change: 0 B Total Size: 7.66 MB ℹ️ View Unchanged
|
|
Flaky tests detected in aeb7c05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23526123657
|
youknowriad
reviewed
Mar 25, 2026
| gutenberg_url( 'build/scripts/vendors/react-jsx-runtime' . $extension ), | ||
| array( 'react' ), | ||
| '18' | ||
| $react_vendor_version |
Contributor
There was a problem hiding this comment.
Using the react version here is good but I'm not a fan of the wp-build changes. I'll comment there.
Member
There was a problem hiding this comment.
A good approach how to extract and use the React version is to generate .asset.php files in the buildVendors function that runs as part of the wp-build build. The version can be extracted during the build, and then this client-asset.php code will just read the .asset.php file and use what's there. That's what most other Gutenberg scripts are doing.
The version can be extracted from the package.json file corresponding to each name in the VENDOR_SCRIPTS array. Also, both react and react-dom export a version string as a named export, that's another way how JS code can detect the version.
The root package.json also works, but doesn't need to be 100% reliable. The might be a semver spec there, like ^18.0.0.
youknowriad
reviewed
Mar 25, 2026
| '{{PREFIX}}': name, | ||
| '{{VERSION}}': version, | ||
| '{{BASE_URL}}': baseUrlExpression, | ||
| '{{REACT_VERSION}}': reactVersion, |
Contributor
There was a problem hiding this comment.
WP build is a generic tool, so we shouldn't add random variables like that IMO.
Contributor
|
If I understand properly, the issue started in this PR #74343 So IMO, that |
Member
|
The caching problem and the related crashes are caused by a regression in #74343 where we switched from React's own UMD build to creating our own bundles. As a preparation for React 19 upgrade, because React 19 doesn't ship the UMD builds any more. The In the old UMD build of Therefore, our new build of What we should have done in #74343 is to change the |
Member
Author
|
Closed in favor of #76811 |
Member
Author
|
Thanks for looking, folks. I'll close in favor of #76811 |
Member
|
#76811 is now merged, implementing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Just a test to follow up on cache versioning for react scripts
package.json (devDependencies or dependencies react field).
fall back to major "18.3.1" for older builds or projects without a react pin.
Follow-up to the approach in #46768, tying ?ver= to the actual bundled React.
What?
Closes
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools