Skip pluggable functions when building for WP Core#76048
Closed
Skip pluggable functions when building for WP Core#76048
Conversation
|
Size Change: 0 B Total Size: 6.87 MB ℹ️ View Unchanged
|
|
Flaky tests detected in ed7e368. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22587372854
|
desrosj
added
[Type] Build Tooling
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
requested review from
aaronjorbin,
dmsnell,
ellatrix,
peterwilsoncc and
youknowriad
8 tasks
github-project-automation
bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
Contributor
|
I believe we should try as much as possible to avoid "specific building for WordPress Core". So I have a strong preference for just removing the conditions. |
Member
Author
I do agree with that. It should be flexible enough so specific conditions for just Core are not required. Closing this in favor of #76062. |
github-project-automation
bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 7.0 Editor Tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Alternative approach to #76062. See #75984.
This adds parsing to remove the
! function_exists()checks that wrap the functions withinpackage/wp-build/templatestemplate files used to generate PHP files during build when the build process is run for WordPress Core.Why?
Functions become what's known as "pluggable" when wrapped in this conditional check. This was a practice that predated the Hooks API (actions/filters) and caused many problems.
"Plugged" versions cannot be trusted to maintain the intended core behavior.
When
wp_*functions exist in WordPress Core, they should not be shipped as pluggable.How?
This removes the
! function_exists()wrapping conditional when building for WordPress Core.