Closed
Conversation
chriszarate
added
[Type] Task
Contributor
|
What happens if two collaborators save at roughly the same time? Do we have a race condition there that could cause even bigger problems? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
In theory, that should be fine. The diff between those two updates should be tiny or empty and similar to what a newly joining or refreshing user should experience. However, it deserves testing in real-world conditions. |
|
Size Change: -24 B (0%) Total Size: 6.84 MB
ℹ️ View Unchanged
|
chriszarate
force-pushed
the
improve/polling-sync-compaction
branch
from
73089a2 to
a3d84ec
Compare
chriszarate
changed the title
Contributor
Author
|
Closing in favor of #75682 due to build/rebase issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the default polling provider, perform compaction using
Y.encodeStateAsUpdateinstead of using a server response.Why?
We have observed some bugginess with the default polling provider that seems aligned with compaction events. In particular, we saw instances of content duplication and we suspect that race conditions between the compaction updates and subsequent updates by the client led to this problem.
How?
Instead of sending updates from the server that need compaction, use
Y.encodeStateAsUpdateto compact using the client's current state. This is a much better approach than combining an arbitrary range of updates from the server's update history.Testing Instructions