Skip to content

wp-build: try without including private APIs #75460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ellatrix wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

wp-build: try without including private APIs #75460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/wp-build/templates/script-registration.php.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,7 @@ if ( ! function_exists( '{{PREFIX}}_register_package_scripts' ) ) {
}
}

add_action( 'wp_default_scripts', '{{PREFIX}}_register_package_scripts' );
// Priority 9 so that the Gutenberg plugin (priority 10) can override
// these scripts with newer versions when it is active.
add_action( 'wp_default_scripts', '{{PREFIX}}_register_package_scripts', 9 );
Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this means Gutenberg won't override Core anymore?

Copy link
Copy Markdown
Member Author

@ellatrix ellatrix Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case?

  • GB active: wp_default_scripts at 10 in GB will override this ones, which is what fixes the problem?
  • GB not active: wp-build scripts are active?

Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GB active: wp_default_scripts at 10 in GB will override this ones, which is what fixes the problem?

Gutenberg runs this template as well. So I thought gutenberg will also get 9 after this PR is merged.

Copy link
Copy Markdown
Member Author

@ellatrix ellatrix Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, for what does GB use this? Don't we only use client-assets.php?

Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client-assets is only for things that are not "refutal scripts or modules", overrides on top of it. Nowadays Gutenberg is almost full wp-build for its own scripts and modules.

Copy link
Copy Markdown
Member Author

@ellatrix ellatrix Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So could we check if we're in the GB plugin or not?

Copy link
Copy Markdown
Contributor

@youknowriad youknowriad Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if there's no other way sure but I wonder if we can find a generic way to make this work.

  • Gutenberg should override Core
  • Plugins should not override Gutenberg, they can override Core too

}
Loading