Skip to content

DataViews: Fix checkbox visibility in grid layout when media is hidden #71231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

DataViews: Fix checkbox visibility in grid layout when media is hidden #71231

wants to merge 3 commits into from

Conversation

Sukhendu2002
Copy link
Contributor

@Sukhendu2002 Sukhendu2002 commented Aug 17, 2025 •
edited
Loading

What?

Fixes checkbox visibility and positioning in DataViews grid layout when media thumbnails are hidden via "Hide Image" in View Options.

Closes: #71219

Testing Instructions

  1. Open the storybook story
  2. Switch to Grid view
  3. Click View Options → Hide "Image"
  4. Hover over items - checkboxes should appear in title row

Screenshots or screencast

Screen.Recording.2025-08-18.at.12.02.09.PM.mov

@Sukhendu2002 Sukhendu2002 changed the title DataViews: Fix checkbox visibility in grid layout when media is hidden [WIP] DataViews: Fix checkbox visibility in grid layout when media is hidden Aug 18, 2025
@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review August 18, 2025 07:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: oandregal <[email protected]>
Co-authored-by: talldan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] DataViews /packages/dataviews labels Aug 19, 2025
@oandregal oandregal requested a review from talldan August 19, 2025 10:32
@oandregal oandregal added the Needs Design Feedback Needs general design feedback. label Aug 19, 2025
@oandregal
Copy link
Member

I checked this with design (Jay), and it's not clear if the media should be hidable for grid (related conversation). If this is still supported, placing the checkbox inline with the title (permanently visible, rather than on hover) seems fine when no media field is set up.

@andrewserong andrewserong mentioned this pull request Aug 28, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oandregal oandregal Awaiting requested review from oandregal oandregal is a code owner

@talldan talldan Awaiting requested review from talldan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Design Feedback Needs general design feedback. [Package] DataViews /packages/dataviews [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataviews: In the grid layout, hiding the media also removes the checkboxes on items and makes them unselectable
3 participants
@Sukhendu2002 @oandregal @t-hamano