Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Fix dependency-group rule to correctly enforce import grouping #69361

Open
wants to merge 14 commits into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Feb 27, 2025

Work in progress

Closes: #65440

What?

Fixes the dependency-group ESLint rule to correctly enforce import order in WordPress projects.

Closes

Why?

The rule was not properly enforcing the expected grouping of imports, allowing misordered imports to pass linting.

How?

  • Fixed the logic in the dependency-group rule to correctly detect and enforce import order across all dependency groups.

Screenshots or screencast

Before

Screen.Recording.2025-03-03.at.5.13.12.PM.mov

After

Screen.Recording.2025-03-03.at.5.11.42.PM.mov

@im3dabasia im3dabasia force-pushed the try/dependecy-group-lint branch from 46a10b9 to f6bb902 Compare February 28, 2025 08:39
Copy link

github-actions bot commented Mar 3, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Mar 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: gigitux <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ESLint]: dependency-group rule doesn't work correctly
1 participant