Fixed Incorrect Text Position issue in Dataviews #68767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
the
[Feature] DataViews
shail-mehta
added
the
[Type] Regression
shail-mehta
changed the title
|
Size Change: +32 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @shail-mehta can you please always use the pull request template, and add the missing information to this PR. |
|
@carolinan I have added testing Instructions and description in this PR. |
t-hamano
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Thanks for the PR!
This PR solves the issue with empty items, but seems to have a visual impact on regular items.
| trunk | This PR |
|---|---|
 |
 |
As you can see, the pattern content is vertically centered. I think patterns with content need to remain top-aligned.
I think this style is also needed on the pattern page.
|
@t-hamano Thanks for the review. I Will work on this. |
|
Flaky tests detected in 8d7d223. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12953209676
|
shail-mehta
force-pushed
the
fix/incorrect-position-issue-in-dataviews
branch
from
10a7cbb to
123c942
Compare
|
@t-hamano I have added empty text message position in center Align Horizontally and vertically |
t-hamano
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Maybe I didn't explain it well enough, but I wasn't proposing to change the field itself, just to add a CSS.
In other words, I think the issue can be resolved by simply adding the following change to the first commit of this PR:
diff --git a/packages/edit-site/src/components/page-patterns/style.scss b/packages/edit-site/src/components/page-patterns/style.scss
index 0fb16e3de5..8a2d71d876 100644
--- a/packages/edit-site/src/components/page-patterns/style.scss
+++ b/packages/edit-site/src/components/page-patterns/style.scss
@@ -10,6 +10,12 @@
height: 100%;
border-radius: $radius-medium;
+ .dataviews-view-grid & {
+ .block-editor-block-preview__container {
+ height: 100%;
+ }
+ }
+
.dataviews-view-table & {
width: 96px;
flex-grow: 0;
|
Apologies for misunderstanding your previous message. 🙏 I will work on this changes. |
shail-mehta
force-pushed
the
fix/incorrect-position-issue-in-dataviews
branch
from
bb8fcac to
8d7d223
Compare
|
Applied Suggested Changes. |
t-hamano
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #68766
Description
For templates, template items, and patterns with empty content, we would expect the DataViews to display "Empty {itemType}" in the center of the item. Alignment issue is not only for empty content its occurring if also have content. Its showing vertically top align and left align Horizontally (Template or pattern) it Should be Vertically and Horizontally Center Align.
Step-by-step Testing instructions