-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Option to display Read More link for latest posts block #22372
base: trunk
Are you sure you want to change the base?
Conversation
Hey @DOUARA, thanks for working on this enhancement! I've just put together a PR (#22654) for improving the instructions for those particular tests. Does this help you solve the issue: |
Hi @talldan, Thanks! I have just added the new attributes to the related fixtures, I think that is gonna solve the issue |
@talldan |
Hey @DOUARA. Some of the end to end tests can fail inconsistently at times. Usually there's an effort to improve them if they fail, but it's sometimes hard to find the ones that are inconsistently failing. Sometimes the best option is just to re-run the tests. If you login to Travis you can do that, though you may have to be a member of the project, I'm not sure. Since you'll soon have a few contributions I think you could be added as a member. This particular test was only introduced yesterday, and it seems problematic so it's been disabled - #22726. If you rebase and push your PR that test shouldn't fail. |
Hi @talldan, |
For Wordpress Twenty Twenty theme. Is this intended to provide a fix for pages with post excerpts not showing an obvious link such as Read more... at the bottom of the post? i.e., leaving just a very unobvious need for a reader to click on the heading of the post ...if the heading hasn't been suppressed? if it is.. I would like to be able to set the size of excerpts in words and provide a Continue reading link to the full Post (however that is phrased). Again if it is.. Anything I can help with? perhaps testing with a live twenty-twenty WP site? |
Hi @DOUARA I see this PR has stopped up. Thanks! I am letting you know about this PR Nik. |
Description
This commit solves the issue #22269
How has this been tested?
Manually in the browser
Screenshots
Types of changes
Checklist: