Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to display Read More link for latest posts block #22372

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

abder
Copy link
Contributor

@abder abder commented May 15, 2020

Description

This commit solves the issue #22269

How has this been tested?

Manually in the browser

Screenshots

Screen Shot 2020-05-15 at 1 57 02 AM

Types of changes

  • The commit adds a new feature to the block named: latest posts.
  • An option as a toggle button to display or hide the Read More link regardless if the excerpt is trimmed or not

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@talldan talldan added [Block] Latest Posts Affects the Latest Posts Block [Type] Enhancement A suggestion for improvement. labels May 27, 2020
@talldan
Copy link
Contributor

talldan commented May 27, 2020

Hey @DOUARA, thanks for working on this enhancement!

I've just put together a PR (#22654) for improving the instructions for those particular tests.

Does this help you solve the issue:
https://github.com/WordPress/gutenberg/blob/769c357903d573dde433fc179060e46965787a1c/packages/e2e-tests/fixtures/blocks/README.md

@abder abder requested review from nerrad and ntwb as code owners May 28, 2020 22:09
@abder
Copy link
Contributor Author

abder commented May 28, 2020

Hi @talldan,

Thanks! I have just added the new attributes to the related fixtures, I think that is gonna solve the issue

@abder
Copy link
Contributor Author

abder commented May 28, 2020

@talldan
Two tests has failed, this time is weird, seems to be out the scope of the changes that I have made, any thoughts?

@talldan
Copy link
Contributor

talldan commented May 29, 2020

Hey @DOUARA. Some of the end to end tests can fail inconsistently at times. Usually there's an effort to improve them if they fail, but it's sometimes hard to find the ones that are inconsistently failing.

Sometimes the best option is just to re-run the tests. If you login to Travis you can do that, though you may have to be a member of the project, I'm not sure. Since you'll soon have a few contributions I think you could be added as a member.

This particular test was only introduced yesterday, and it seems problematic so it's been disabled - #22726.

If you rebase and push your PR that test shouldn't fail.

@abder
Copy link
Contributor Author

abder commented May 29, 2020

Hi @talldan,
it worked!

@crislar
Copy link

crislar commented Jul 23, 2020

For Wordpress Twenty Twenty theme. Is this intended to provide a fix for pages with post excerpts not showing an obvious link such as Read more... at the bottom of the post? i.e., leaving just a very unobvious need for a reader to click on the heading of the post ...if the heading hasn't been suppressed?

if it is.. I would like to be able to set the size of excerpts in words and provide a Continue reading link to the full Post (however that is phrased).

Again if it is.. Anything I can help with? perhaps testing with a live twenty-twenty WP site?

@paaljoachim
Copy link
Contributor

Hi @DOUARA

I see this PR has stopped up.
Are you able to continue working on it?

Thanks!

I am letting you know about this PR Nik.
@ntsekouras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants