Fix the missing archive template in Poetry #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #131 |
MaggieCabrera
force-pushed
the
fix/poetry/archive
branch
from
a5a2363 to
c9cb945
Compare
| @@ -9,16 +9,16 @@ | |||
| <!-- wp:group {"style":{"spacing":{"padding":{"top":"32px","bottom":"64px"}}},"layout":{"type":"constrained"}} --> | |||
| <div class="wp-block-group" style="padding-top:32px;padding-bottom:64px"><!-- wp:group {"style":{"spacing":{"blockGap":"64px"}},"layout":{"type":"flex","flexWrap":"nowrap"}} --> | |||
| <div class="wp-block-group"><!-- wp:group {"style":{"spacing":{"blockGap":"88px"}},"layout":{"type":"flex","orientation":"vertical"}} --> | |||
| <div class="wp-block-group"><!-- wp:site-title {"level":0,"isLink":false,"style":{"typography":{"fontSize":"24px","fontStyle":"normal","fontWeight":"600"}},"textColor":"custom-text"} /--> | |||
| <div class="wp-block-group"><!-- wp:site-title {"level":0,"isLink":false,"style":{"typography":{"fontStyle":"normal","fontWeight":"600"}},"fontSize":"medium"} /--> | |||
There was a problem hiding this comment.
I changed the font sizes to use preset values so the pattern works better in other themes too. To do this I updated theme.json with preset values that use the same slugs as core
|
|
||
| <!-- wp:group {"style":{"spacing":{"blockGap":"48px"}},"layout":{"type":"flex","orientation":"vertical"}} --> | ||
| <div class="wp-block-group"><!-- wp:heading {"level":1} --> | ||
| <h1>Food <br>for thoughts</h1> |
There was a problem hiding this comment.
I removed headings from the header since they appear in almost all pages. We may want the h1 to be something else like the title of a page/post or the archive title instead. I used the preset font sizes instead to keep the same styling for the paragraphs
|
@sandroschutt I made a few changes to your PR and explained the reasoning behind them. I will bring this in, but we can iterate if we think it needs some adjustment! |
MaggieCabrera
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a basic template for categories, tags and other base archives in the Poetry theme.