GH Actions/unit-tests: don't run code coverage in forks #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unit-tests` workflow runs code coverage for pushes to `main` and pull requests, but wasn't limited to this repo. This resulted in failing builds for contributors who have actions enabled on their fork. The reason for the failure is that they don't have access to the `CODECOV_TOKEN`. This commit changes the conditions on when to run the tests normally and when to run with code coverage to take the organisation where the repo lives into account. That should prevent the failing builds in forks.
jrfnl
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
Thanks @rodrigoprimo ! LGTM.
I wonder if we shouldn't improve the workflow organisation to only have code coverage in the unit-test.yml workflow - probably via a separate job, but that's for a future iteration.
dingo-d
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unit-testsworkflow runs code coverage for pushes tomainand pull requests, but wasn't limited to this repo.This resulted in failing builds for contributors who have actions enabled on their fork. The reason for the failure is that they don't have access to the
CODECOV_TOKEN.This commit changes the conditions on when to run the tests normally and when to run with code coverage to take the organisation where the repo lives into account. That should prevent the failing builds in forks.
Similar to #2542, which applied the same change to the
quicktestworkflow.