Merged
Conversation
…t key options must be an object and the length of the secret must be at least 8 chars
…med to input/output encoding and finished encrypt tests
…hPassword returns result instead of hash
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates TypeScript configurations and refactors the cipher-kit API with several key improvements, including renamed function parameters, enhanced test coverage, and package dependency updates.
- Updates TypeScript target to ES2022 and module resolution to bundler across packages
- Renames API options properties for better clarity (e.g.,
encoding→outputEncoding/inputEncoding) - Adds comprehensive test coverage with new test files and helper utilities
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/*/tsconfig.json | Updated TypeScript configuration to ES2022 target and bundler module resolution |
| packages/compress-kit/src/compress.ts | Increased compression memLevel from 7 to 8 |
| packages/cipher-kit/src/web/web-encrypt.ts | Renamed API options properties and improved validation logic |
| packages/cipher-kit/src/web/kit.ts | Updated documentation and function signatures to match API changes |
| packages/cipher-kit/src/helpers/validate.ts | Renamed matchPattern to matchEncryptedPattern and improved validation functions |
| packages/cipher-kit/src/tests/* | Added comprehensive test suite with new test files and helpers |
| packages/cipher-kit/README.md | Updated documentation to reflect API changes and improvements |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
547
to
552
| * @example | ||
| * const {result, salt} = await hashPassword("my-password"); | ||
| * | ||
| * await verifyPassword("my-password", result, salt); // true | ||
| * await verifyPassword("wrong-password", result, salt); // false | ||
| * ``` |
There was a problem hiding this comment.
The example is missing opening comment asterisk for proper JSDoc formatting.
| * @returns `true` if the password matches, otherwise `false`. | ||
| * | ||
| * @example | ||
| * ```ts |
There was a problem hiding this comment.
The example is missing opening comment asterisk for proper JSDoc formatting.
Suggested change
| * ```ts | |
| * ```ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.