Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible folding factors for different rounds. #32

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Flexible folding factors for different rounds. #32

merged 7 commits into from
Feb 24, 2025

Conversation

yczhangsjtu
Copy link
Contributor

Solve #31

@yczhangsjtu
Copy link
Contributor Author

Additionally:

  • Added some comments.
  • Code formats.

@yczhangsjtu
Copy link
Contributor Author

Instead of an array, I introduced an enum FoldFactor that provides an at_round(usize) method.

@WizardOfMenlo
Copy link
Owner

Can I review this or is it still WIP?

@yczhangsjtu
Copy link
Contributor Author

It's ready for review.

WizardOfMenlo
WizardOfMenlo approved these changes Feb 20, 2025
View reviewed changes
Copy link
Owner

@WizardOfMenlo WizardOfMenlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks for the PR!
Just a tiny fix to the printing in the parameters.rs file and LGTM!

@WizardOfMenlo WizardOfMenlo merged commit 5f6ff22 into WizardOfMenlo:main Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WizardOfMenlo WizardOfMenlo WizardOfMenlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yczhangsjtu @WizardOfMenlo