Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 토큰값 누락으로 재배포

😅 미완성 작업

  • Task1

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • 신규 기능
    • 해당 PR에서 사용자에게 직접 보이는 신규 기능은 없습니다.
  • 리팩터링
    • 클라이언트 초기화 관련 설정을 정적으로 정리해 구성 일관성과 예측 가능성을 강화했습니다.
  • 작업
    • 내부 환경설정만 조정되었으며 앱의 기능, 화면, 동작에는 변화가 없습니다.
    • 빌드/배포 환경과 무관하게 동일한 설정이 적용되도록 정비되었습니다.

Walkthrough

환경 변수 기반 Firebase 구성 값을 하드코딩된 리터럴로 대체했습니다. initializeApp, 메시징 초기화, 토큰 생성 및 서비스 워커 등록 로직은 유지되었습니다. 토큰 생성 시 사용되는 VAPID 키는 여전히 환경 변수에서 읽습니다. 공개 API 시그니처 변경은 없습니다.

Changes

Cohort / File(s) Change Summary
Firebase 설정 하드코딩
src/firebase/firebase.ts
apiKey, authDomain, projectId, storageBucket, messagingSenderId, appId, measurementId를 환경 변수에서 상수 리터럴로 교체. 앱/메시징 초기화 및 토큰 생성 흐름은 변경 없음. VAPID 키는 여전히 환경 변수 사용.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d23cd30 and e29d228.

📒 Files selected for processing (1)
  • src/firebase/firebase.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit c26093f into main Aug 13, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 15, 2025
10 tasks
@yeonjin719 yeonjin719 changed the title 배포 [Deploy] 배포 Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants