Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

#93

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 사파리에서도 폰트가 적용되도록 설정 추가

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 10, 2025
@yeonjin719 yeonjin719 linked an issue Aug 10, 2025 that may be closed by this pull request
1 task
@coderabbitai
Copy link

coderabbitai bot commented Aug 10, 2025

Summary by CodeRabbit

  • 스타일
    • 전역 기본 글꼴을 Pretendard로 적용하여 본문, 버튼, 입력, 선택, 텍스트 영역 등 UI 전반의 타이포그래피를 개선했습니다. 폰트는 CDN을 통해 로드되며 미지원 환경에서는 산세리프 계열로 폴백됩니다. 시각적 일관성과 가독성이 향상되며 기능 동작에는 영향이 없습니다. 추가적인 레이아웃이나 색상 변경은 없습니다.

Summary by CodeRabbit

  • Style
    • Pretendard 폰트가 글로벌 스타일로 적용되어 전체 앱에서 새로운 글꼴이 사용됩니다.

Walkthrough

새로운 CSS 파일 src/App.css가 추가되어 Pretendard 폰트를 CDN에서 불러오고, html, body, button, input, select, textarea에 'Pretendard', sans-serif 폰트 패밀리를 글로벌로 지정했습니다. 다른 스타일 규칙은 없습니다.

Changes

Cohort / File(s) Change Summary
글로벌 폰트 스타일 추가
src/App.css
Pretendard 폰트 CDN import 및 html, body, button, input, select, textarea에 폰트 패밀리 글로벌 지정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2분

Suggested reviewers

  • yujin5959
  • SEBINorSEBOUT

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8bd25e and 41b76e5.

📒 Files selected for processing (1)
  • src/App.css (1 hunks)
🔇 Additional comments (2)
src/App.css (2)

3-10: Safari 대응을 위한 글로벌 폰트 적용, 스택 구성 모두 적절합니다

폼 컨트롤까지 포함한 선택자와 한글/시스템 폴백을 충분히 넣은 스택 구성이 좋습니다. Safari에서의 미적용 이슈 해결에 효과적입니다.


1-10: src/App.css 번들 포함 확인 완료

  • src/App.tsx 1번째 줄에 import './App.css';가 있어 CSS가 번들에 포함되어 적용됩니다.

추가 확인이나 조치가 필요 없습니다.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fdc4c2 and e8bd25e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
📒 Files selected for processing (1)
  • src/App.css (1 hunks)
🔇 Additional comments (2)
src/App.css (2)

3-5: Safari 폰트 적용 버그 픽스 방향 적절합니다

글로벌로 Pretendard를 적용하는 접근은 Safari 이슈 해결에 직접적입니다. 기본 동작은 LGTM입니다.


1-5: App.css 로드 확인 완료

  • JS/TS 진입점에서 import './App.css';로 App.css가 번들에 포함됨
  • index.html에는 직접 링크가 없지만, 번들러가 CSS import를 처리하므로 스타일이 정상 적용됨

추가 조치 불필요합니다.

@yeonjin719 yeonjin719 merged commit 4e12a14 into develop Aug 12, 2025
3 checks passed
@yeonjin719 yeonjin719 deleted the bugfix/#93 branch August 12, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 사파리 폰트 적용 문제 해결

2 participants