-
Notifications
You must be signed in to change notification settings - Fork 2
[BugFix] 사파리 폰트 설정 추가 #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
Summary by CodeRabbit
Walkthrough새로운 CSS 파일 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2분 Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock,!**/*.lock
📒 Files selected for processing (1)
src/App.css(1 hunks)
🔇 Additional comments (2)
src/App.css (2)
3-5: Safari 폰트 적용 버그 픽스 방향 적절합니다글로벌로 Pretendard를 적용하는 접근은 Safari 이슈 해결에 직접적입니다. 기본 동작은 LGTM입니다.
1-5: App.css 로드 확인 완료
- JS/TS 진입점에서
import './App.css';로 App.css가 번들에 포함됨- index.html에는 직접 링크가 없지만, 번들러가 CSS import를 처리하므로 스타일이 정상 적용됨
추가 조치 불필요합니다.
🚨 관련 이슈
#93
✨ 변경사항
✏️ 작업 내용
😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항