Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

#102

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 서드파티 쿠키 문제인가 싶어서 배포, 테스트 후 이렇게 바꿔도 동작 안하면 추후 롤백 시키겠습니다.

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 13, 2025
@yeonjin719 yeonjin719 linked an issue Aug 13, 2025 that may be closed by this pull request
2 tasks
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • Refactor

    • API 요청 경로를 /api로 통일해 네트워크 호출 흐름을 단순화했습니다.
  • Chores

    • 개발 서버에 프록시를 적용해 /api 요청을 환경 변수로 지정된 백엔드로 전달합니다.
    • 실행 모드별로 환경 변수를 로드해 설정이 자동 반영되도록 구성했습니다.
    • 환경 전환 시 동일한 API 경로를 유지합니다.
    • 사용자 기능 및 UI 변화는 없습니다.

Walkthrough

axiosInstance의 baseURL을 환경변수 기반 URL에서 '/api'로 변경. Vite 설정을 함수형으로 전환하고 loadEnv로 환경변수를 로드. 개발 서버에 '/api' 프록시를 추가하여 VITE_API_BASE_URL로 포워딩하며 경로 재작성('/api' 제거)과 보안/오리진 설정을 적용.

Changes

Cohort / File(s) Summary
Axios 인스턴스 기본 경로 업데이트
src/api/axiosInstance.ts
baseURL을 import.meta.env.VITE_API_BASE_URL에서 '/api'로 변경. 나머지 설정 및 인터셉터는 그대로. 공개 API 시그니처 변화 없음.
Vite 동적 설정 및 프록시 도입
vite.config.ts
정적 설정에서 함수형 설정으로 전환. loadEnvVITE_API_BASE_URL 로드. server.proxy/api → 대상 URL 프록시, changeOrigin: true, secure: true, 경로에서 /api 제거. 기존 plugins/host/port/alias 유지. 기본 내보내기 시그니처 함수형으로 변경.

Sequence Diagram(s)

sequenceDiagram
  participant B as Browser (Axios)
  participant F as Frontend (/api baseURL)
  participant V as Vite Dev Server (Proxy)
  participant S as Backend API (VITE_API_BASE_URL)

  B->>F: axios 요청 to /api/...
  F->>V: HTTP /api/...
  V->>V: /api prefix 제거 (rewrite)
  V->>S: 포워딩 to VITE_API_BASE_URL/...
  S-->>V: 응답
  V-->>F: 프록시 응답
  F-->>B: 응답 반환
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e29d228 and 10326fb.

📒 Files selected for processing (2)
  • src/api/axiosInstance.ts (1 hunks)
  • vite.config.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit 0fe6e4e into develop Aug 13, 2025
2 of 3 checks passed
@yeonjin719 yeonjin719 deleted the bugfix/#102 branch August 13, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 서드파티 쿠키 테스트

2 participants