device: have IpcSetOperation not return typed error #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the golang.org/x/sys/unix dependency and use the newly introduced RTMGRP_* consts instead of using the corresponding RTNLGRP_* const to create a mask. Signed-off-by: Tobias Klauser <[email protected]> Signed-off-by: Jason A. Donenfeld <[email protected]>
Signed-off-by: David Crawshaw <[email protected]>
zx2c4
reviewed
Mar 20, 2020
| status = device.IpcSetOperation(buffered.Reader) | ||
| err := device.IpcSetOperation(buffered.Reader) | ||
| if err != nil { | ||
| status, _ = err.(*IPCError) |
There was a problem hiding this comment.
Isn't there a new Go 1.13 error API for this?
There was a problem hiding this comment.
There is. In 1.13 this could be:
if !errors.As(err, &status) {
device.log.Error.Println("Invalid UAPI error:", err)
status = &IPCError{1}
}
...
|
Shouldn't you be doing this to IpcGet as well as IpcSet? |
danderson
approved these changes
Apr 1, 2020
| status = device.IpcSetOperation(buffered.Reader) | ||
| err := device.IpcSetOperation(buffered.Reader) | ||
| if err != nil { | ||
| status, _ = err.(*IPCError) |
There was a problem hiding this comment.
There is. In 1.13 this could be:
if !errors.As(err, &status) {
device.log.Error.Println("Invalid UAPI error:", err)
status = &IPCError{1}
}
...
|
Closing in favor of #17. |
nshalman
pushed a commit
to nshalman/wireguard-go
that referenced
this pull request
Apr 23, 2023
Signed-off-by: Jordan Whited <[email protected]>
spikecurtis
pushed a commit
to coder/wireguard-go
that referenced
this pull request
Mar 29, 2024
Signed-off-by: Jordan Whited <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.