Fix expandauth_tests for new generate() API#261
Merged
Conversation
jglanz
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expandauth_tests.cppto use the newprivate_key_type::generate(private_key_type::key_type::em)API instead of the removedgenerate<em::private_key_shim>()templatefeature/ed-sig-key) and Add get_permission_lower_bound intrinsic and expandauth action #253 (feature/get-permission-host) being merged back-to-back — Add get_permission_lower_bound intrinsic and expandauth action #253 added the expandauth tests using the old generate API, then Embed ED25519 public key in signature blob #257 changed that API