Embed ED25519 public key in signature blob#38
Merged
Conversation
Update ed_signature from 64 to 96 bytes to match the new self-contained ED25519 signature format: [0..31] 32-byte public key + [32..95] 64-byte signature. This eliminates the need for separate ed_pubkey_extension in transaction extensions. Companion to wire-sysio ed-sig-key changes.
jglanz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ed_signaturefrom 64 to 96 bytes to match new self-contained ED25519 signature format[0..31]32-byte public key +[32..95]64-byte signatureed_pubkey_extensionin transaction extensionsContext
Companion to wire-sysio
feature/ed-sig-keybranch changes (Wire-Network/wire-sysio#257). The embedded public key makes ED25519 signatures recoverable through the samerecover()path as K1/R1, removing client complexity and extension ordering dependencies.