Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapack version 48 item support #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

datapack version 48 item support #124

wants to merge 2 commits into from

Conversation

Samma2009
Copy link

No description provided.

WingedSeal
WingedSeal requested changes Jan 12, 2025
View reviewed changes
src/jmc/compile/command/builtin_function/jmc_command.py Outdated
@@ -1120,7 +1119,7 @@ def call(self) -> str:
if self.args["namespace"] == ""
else self.args["namespace"]
)
ADVANCEMENT = "advancement" if self.datapack.version >= 48 else "advancements"
ADVANCEMENT = self.datapack.version >= 48 and "advancement" or "advancements"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of making it harder to read

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yhea sorry this is caused by me reversting the version thing

src/jmc/compile/command/builtin_function/jmc_command.py Outdated
@@ -1189,7 +1188,7 @@ def call(self) -> str:
if self.args["namespace"] == ""
else self.args["namespace"]
)
ADVANCEMENT = "advancement" if self.datapack.version >= 48 else "advancements"
ADVANCEMENT = self.datapack.version >= 48 and "advancement" or "advancements"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

src/jmc/compile/datapack.py Outdated
:param token_dict: Dictionary of string and Token
:return: String that looks like object
"""
pairs = []
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I did it like this but please do pairs: list[type_here] = []

@WingedSeal WingedSeal added Priority: Medium This should be looked into within a few days Status: Change needed Something need to be changed before pull request can be accepted labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WingedSeal WingedSeal WingedSeal requested changes

Assignees
No one assigned
Labels
Priority: Medium This should be looked into within a few days Status: Change needed Something need to be changed before pull request can be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samma2009 @WingedSeal