Planetary Conditions#25
Open
Windchild292 wants to merge 30 commits intomasterfrom
Open
Conversation
… more proper way for it to be named
Windchild292
commented
Jun 11, 2022
| || (hasWorkingMisc(MiscType.F_HIRES_IMAGER) | ||
| && ((game.getPlanetaryConditions().getLight() == PlanetaryConditions.L_DAY) | ||
| || (game.getPlanetaryConditions().getLight() == PlanetaryConditions.L_DUSK))); | ||
| || (hasWorkingMisc(MiscType.F_HIRES_IMAGER) && !game.getPlanetaryConditions().getLight().isNight()); |
Owner
Author
There was a problem hiding this comment.
Check this out, as it may be a bug
Comment on lines
+2787
to
+2789
| return !isAirborne() || hasWorkingMisc(MiscType.F_RECON_CAMERA) || hasWorkingMisc(MiscType.F_INFRARED_IMAGER) | ||
| || hasWorkingMisc(MiscType.F_HYPERSPECTRAL_IMAGER) | ||
| || (hasWorkingMisc(MiscType.F_HIRES_IMAGER) | ||
| && ((game.getPlanetaryConditions().getLight() == PlanetaryConditions.L_DAY) | ||
| || (game.getPlanetaryConditions().getLight() == PlanetaryConditions.L_DUSK)))) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| || (hasWorkingMisc(MiscType.F_HIRES_IMAGER) && !game.getPlanetaryConditions().getLight().isNight()); |
Owner
Author
There was a problem hiding this comment.
No source, nor is it in the books/ errata... and this is also likely bugged
Comment on lines
+32623
to
32635
| // FIXME : Windchild I'm pretty sure this shouldn't stack | ||
| if (game.getPlanetaryConditions().getWeather().isHeavySnow() | ||
| || game.getPlanetaryConditions().getWeather().isIceStorm() | ||
| || game.getPlanetaryConditions().getWeather().isDownpour() | ||
| || game.getPlanetaryConditions().getWindStrength().isStrongGale()) { | ||
| rollTarget.addModifier(2, "Bad Weather"); | ||
| } | ||
|
|
||
| if ((game.getPlanetaryConditions().getWindStrength() >= PlanetaryConditions.WI_STORM) | ||
| || ((game.getPlanetaryConditions().getWeather() == PlanetaryConditions.WE_HEAVY_SNOW) && (game | ||
| .getPlanetaryConditions().getWindStrength() == PlanetaryConditions.WI_STRONG_GALE))) { | ||
| if (game.getPlanetaryConditions().getWindStrength().isStormOrStronger() | ||
| || (game.getPlanetaryConditions().getWeather().isHeavySnow() | ||
| && game.getPlanetaryConditions().getWindStrength().isStrongGale())) { | ||
| rollTarget.addModifier(3, "Really Bad Weather"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Phase 2:
For Reviewers:
PlanetaryConditions::isVacuum actually means isVacuum or isTrace, not just isVacuum.
PlanetaryConditions::isSearchlightEffective means isNight