WIP | Support Python = 3.8+ in JSON logger #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_logger doesn't work with Python 3.8=+ due to (last working is Python 3.7)
fmt
toformat
in logging%
formatting being neededThis fixes the usage to newer logging behaviour
This fix won't make it enough to work with newer Python (3.12=+) releases, because this entire package uses
pkg_resources
, which is deprecated and/or removed in new Python releases (removed in Python 3.12) - this would also would have to be fixedOn older Python releases you will get a warning instead
This is thus fixable with limiting support to old python release, rewriting python-commons to use importlibs (preferred), or installing setuptools as dependency.
I don't have the time to fix it further