[UI] 동아리 목록 컴포넌트 구현 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough새 DTO Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant MyPageScreen
participant ViewModel
participant MyClubComponent as MyClubComponent (UI)
participant Nav as Navigation
Note over MyPageScreen,MyClubComponent: MyClubComponent 도입 및 콜백 연결
User->>MyPageScreen: 마이페이지 진입
MyPageScreen->>ViewModel: koinViewModel()로 ViewModel 주입
MyPageScreen->>MyClubComponent: myClubs, onDeleteClub, onNavigateToAddClub 전달
rect rgba(200,240,255,0.18)
Note right of MyClubComponent: 목록 렌더링 (LazyColumn)
end
User->>MyClubComponent: "추가하기" 클릭
MyClubComponent->>Nav: onNavigateToAddClub()
Note over Nav: 추가 화면으로 네비게이션
User->>MyClubComponent: 삭제 아이콘 클릭
MyClubComponent-->>MyPageScreen: onDeleteClub(clubId)
Note over MyPageScreen: 삭제 처리 로직 연결은 TODO
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyClubComponent.kt (1)
97-104: MyClubItem의 modifier 파라미터가 쓰이지 않아요전달받은
modifier를 무시하고 있어서 외부에서 레이아웃을 조정하기 어렵습니다. 전달값을 Row에 적용하도록 바꿔 주세요.- Row( - modifier = Modifier - .fillMaxWidth(), + Row( + modifier = modifier + .fillMaxWidth(),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composeApp/src/commonMain/composeResources/files/ic_x.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
composeApp/src/commonMain/kotlin/org/whosin/client/data/dto/response/MyClubResponseDto.kt(1 hunks)composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/MyPageScreen.kt(4 hunks)composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyClubComponent.kt(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/MyPageScreen.kt (3)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyPageTopAppBar.kt (1)
MyPageTopAppBar(19-29)composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyClubComponent.kt (1)
MyClubComponent(33-89)composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyPageButton.kt (1)
MyPageButton(18-39)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/component/MyClubComponent.kt (1)
composeApp/src/commonMain/kotlin/ui/theme/Type.kt (1)
pretendardFontFamily(14-38)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: android-build
- GitHub Check: ios-build
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/mypage/MyPageScreen.kt
Outdated
Show resolved
Hide resolved
This was referenced Oct 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 이슈번호
✏️ 변경사항
📷 스크린샷
Screen_Recording_20250928_224633_WhosInClient.mp4
✍️ 사용법
🎸 기타
Summary by CodeRabbit