Skip to content

Conversation

@Nico1eKim
Copy link
Contributor

@Nico1eKim Nico1eKim commented Sep 23, 2025

๐Ÿš€ ์ด์Šˆ๋ฒˆํ˜ธ

โœ๏ธ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • png๋กœ ์ ์šฉ๋๋˜ ์•„์ด์ฝ˜ ํŒŒ์ผ๋“ค์„ svg๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค

๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท

โœ๏ธ ์‚ฌ์šฉ๋ฒ•

  • png๋Š” drawable์•ˆ์— ๋„ฃ๊ณ  svg๋Š” files ์•ˆ์— ๋„ฃ์–ด์„œ svg๋ฅผ ์“ธ ๋•Œ๋Š” AsyncImage์— model๋กœ Res.getUri("files/ic_hamburger.svg") ์ด๋Ÿฐ์‹์œผ๋กœ ๋„ฃ์–ด์„œ ์“ฐ๋ฉด ๋ฉ๋‹ˆ๋‹ค

๐ŸŽธ ๊ธฐํƒ€

Summary by CodeRabbit

  • ์‹ ๊ธฐ๋Šฅ
    • ์•ฑ ์ „๋ฐ˜์— SVG ์ด๋ฏธ์ง€ ๋กœ๋”ฉ์„ ์ง€์›ํ•ด ์•„์ด์ฝ˜๊ณผ ํ”„๋กœํ•„ ์ด๋ฏธ์ง€๊ฐ€ ํ•ด์ƒ๋„์— ๋งž์ถฐ ์„ ๋ช…ํ•˜๊ฒŒ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
    • ํ™ˆ ํ™”๋ฉด์˜ ๋ฉ”๋‰ด, ๋งˆ์ดํŽ˜์ด์ง€, ์ƒˆ๋กœ๊ณ ์นจ ์•„์ด์ฝ˜์ด ํ”Œ๋žซํผ ์ „๋ฐ˜์—์„œ ์ผ๊ด€๋˜๊ฒŒ ๋ Œ๋”๋ง๋ฉ๋‹ˆ๋‹ค.
    • ๋„คํŠธ์›Œํฌ ๊ธฐ๋ฐ˜ ์ด๋ฏธ์ง€ ๋กœ๋”ฉ์„ ํ™œ์šฉํ•ด ๋‹ค์–‘ํ•œ ํ™˜๊ฒฝ์—์„œ ์ด๋ฏธ์ง€ ํ‘œ์‹œ์˜ ์•ˆ์ •์„ฑ๊ณผ ํ˜ธํ™˜์„ฑ์ด ํ–ฅ์ƒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
  • ์žก๋ฌด
    • iOS ์‹œ๋ฎฌ๋ ˆ์ดํ„ฐ ๋Œ€์ƒ ์ถ”๊ฐ€ ๋ฐ SVG ๊ด€๋ จ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์˜์กด์„ฑ์ด ๊ณตํ†ต ์ฝ”๋“œ์— ํ†ตํ•ฉ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

@Nico1eKim Nico1eKim self-assigned this Sep 23, 2025
@Nico1eKim Nico1eKim added REFACTOR ๊ธฐ๋Šฅ์„ ๊ฑด๋“œ๋ฆฌ์ง€ ์•Š๋Š” ๋ฆฌํŒฉํ† ๋ง OK Merge ์™„๋ฃŒ๋œ PR labels Sep 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

ํ™ˆ ํ™”๋ฉด๊ณผ ๋ฉค๋ฒ„ ์•„์ดํ…œ์˜ ์ •์  ๋ฆฌ์†Œ์Šค ์ด๋ฏธ์ง€๋ฅผ Coil AsyncImage(URI ๊ธฐ๋ฐ˜)๋กœ ์ „ํ™˜ํ•˜๊ณ , Coil 3 SVG/๋„คํŠธ์›Œํฌ ๊ด€๋ จ ์˜์กด์„ฑ๊ณผ iOS ์‹œ๋ฎฌ๋ ˆ์ดํ„ฐ ํƒ€๊นƒ์„ ๋นŒ๋“œ ์„ค์ •์— ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ณต๊ฐœ API ์‹œ๊ทธ๋‹ˆ์ฒ˜์™€ ๋กœ์ง ํ๋ฆ„์€ ๋ณ€๊ฒฝ๋˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.

Changes

Cohort / File(s) Change Summary
๋นŒ๋“œ ์„ค์ • & ๋ฒ„์ „ ์นดํƒˆ๋กœ๊ทธ
composeApp/build.gradle.kts, gradle/libs.versions.toml
Coil 3 ๊ด€๋ จ ์˜์กด์„ฑ ๋ฐ ๋ฒ„์ „ ์ถ”๊ฐ€(coil-compose, coil-network-ktor3, coil-network-okhttp, coil-svg, version coilSvg = "3.3.0"). iOS ์‹œ๋ฎฌ๋ ˆ์ดํ„ฐ ํƒ€๊นƒ(iosSimulatorArm64) ์ถ”๊ฐ€.
ํ™ˆ ํ™”๋ฉด (SVG ๋กœ๋“œ ์ „ํ™˜)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/HomeScreen.kt
Image(painterResource(...)) ์‚ฌ์šฉ ๋ถ€๋ถ„์„ AsyncImage(model = Res.getUri("files/...svg"))๋กœ ๊ต์ฒด. ๊ด€๋ จ import ์ •๋ฆฌ. ๋ ˆ์ด์•„์›ƒ/์ด๋ฒคํŠธ ๋กœ์ง ๋ถˆ๋ณ€.
๋ฉค๋ฒ„ ์•„์ดํ…œ (์•„๋ฐ”ํƒ€ SVG ์ „ํ™˜)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/component/PresentMembersItem.kt
ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋ชฉ๋ก์„ drawable ์ƒ์ˆ˜์—์„œ "files/ic_eyes_*.svg" ๊ฒฝ๋กœ ๋ฌธ์ž์—ด๋กœ ๋ณ€๊ฒฝํ•˜๊ณ  AsyncImage(model = Res.getUri(imageRes))๋กœ ๋กœ๋”ฉํ•˜๋„๋ก ์ „ํ™˜. ๊ด€๋ จ import ์ •๋ฆฌ. ์‹œ๊ทธ๋‹ˆ์ฒ˜ ๋ถˆ๋ณ€.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as Compose UI
  participant AsyncImage as Coil AsyncImage
  participant Coil as Coil Engine
  participant Decoder as SVG Decoder
  participant FS as Local Files
  participant Net as Network (OkHttp/Ktor)

  User->>UI: ํ™”๋ฉด ๋ Œ๋”๋ง ์š”์ฒญ
  UI->>AsyncImage: model = Res.getUri("files/*.svg")
  AsyncImage->>Coil: ์ด๋ฏธ์ง€ ์š”์ฒญ
  alt ๋กœ์ปฌ ํŒŒ์ผ URI
    Coil->>FS: ํŒŒ์ผ ์ฝ๊ธฐ
    FS-->>Coil: ๋ฐ”์ดํŠธ ์ŠคํŠธ๋ฆผ
  else ์›๊ฒฉ ์ž์› (ํ•ด๋‹น ์‹œ)
    Coil->>Net: ๋„คํŠธ์›Œํฌ ์š”์ฒญ
    Net-->>Coil: ์‘๋‹ต ์ŠคํŠธ๋ฆผ
  end
  Coil->>Decoder: SVG ๋””์ฝ”๋”ฉ
  Decoder-->>Coil: ๋””์ฝ”๋”ฉ ๊ฒฐ๊ณผ
  Coil-->>AsyncImage: ๋ Œ๋”๋ง ๊ฐ€๋Šฅํ•œ ์ด๋ฏธ์ง€ ์ „๋‹ฌ
  AsyncImage-->>UI: ์ปดํฌ์ง€์…˜์— ๊ทธ๋ฆฌ๊ธฐ
Loading

Estimated code review effort

๐ŸŽฏ 3 (Moderate) | โฑ๏ธ ~20 minutes

Poem

SVG๊ฐ€ ์™€์„œ ์„ ์„ ๊ทธ๋ฆฌ๋„ค โœจ
AsyncImage๊ฐ€ ์†์‚ญ์—ฌ URI๋ฅผ ๋ถ€๋ฅด๊ณ 
Coil์ด ๋ฐ›์•„ ๋‹ด์•„ ์„ ๋ช…ํžˆ ๋ณด์—ฌ์ฃผ๋„ค.
ํ™ˆ๊ณผ ๋ฉค๋ฒ„, ๊ทธ๋ฆผ์ด ๊ฐ€๋ฒผ์›Œ์ง„ ๋‚ โ€”
์ž‘์€ ๋ณ€๊ฒฝ, ๋šœ๋ ทํ•œ ๋ชจ์Šต.

Pre-merge checks and finishing touches

โŒ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes Check โš ๏ธ Warning ๋Œ€์ฒด๋กœ ๋ณ€๊ฒฝ์‚ฌํ•ญ์€ PNGโ†’SVG ์ „ํ™˜๊ณผ ์—ฐ๊ด€๋˜๋‚˜ ๋นŒ๋“œ ์„ค์ •๊ณผ ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์„ ์–ธ ์ค‘ ์ผ๋ถ€๋Š” ์ด ์ด์Šˆ์˜ ํ•ต์‹ฌ ๋ชฉ์ ๊ณผ ์ง์ ‘ ๊ด€๋ จ์ด ์—†์–ด ๋ณด์ž…๋‹ˆ๋‹ค; ๊ตฌ์ฒด์ ์œผ๋กœ iosSimulatorArm64 ํƒ€๊นƒ ์ถ”๊ฐ€์™€ libs.versions.toml์˜ coil-network-okhttp ํ•ญ๋ชฉ์€ ์ฝ”๋“œ์—์„œ ์‚ฌ์šฉ ํ”์ ์ด๋‚˜ PR ์„ค๋ช…์ƒ ๊ทผ๊ฑฐ๊ฐ€ ๋ช…ํ™•ํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค. ๋ถˆํ•„์š”ํ•œ ๋นŒ๋“œ ์„ค์ • ๋ณ€๊ฒฝ์ด๋‚˜ ์‚ฌ์šฉ๋˜์ง€ ์•Š๋Š” ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์„ ์–ธ์€ ์ œ๊ฑฐํ•˜๊ฑฐ๋‚˜ PR ์„ค๋ช…์— ๋ณ€๊ฒฝ ์‚ฌ์œ ๋ฅผ ๋ช…ํ™•ํžˆ ์ ์–ด ์ฃผ์„ธ์š”; ์ •๋‹นํ•œ ์ด์œ ๊ฐ€ ์žˆ๋‹ค๋ฉด ์ฝ”๋ฉ˜ํŠธ๋กœ ๊ทผ๊ฑฐ๋ฅผ ๋‚จ๊ฒจ ์ฃผ์‹œ๊ธฐ ๋ฐ”๋ž๋‹ˆ๋‹ค.
โœ… Passed checks (4 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title Check โœ… Passed PR ์ œ๋ชฉ "[REFACTOR] png to svg"์€ ๋ณ€๊ฒฝ์˜ ํ•ต์‹ฌ์ธ PNG์—์„œ SVG๋กœ์˜ ์ „ํ™˜์„ ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์š”์•ฝํ•˜๊ณ  ์žˆ์–ด ๋ณธ ๋ณ€๊ฒฝ์‚ฌํ•ญ๊ณผ ์ผ์น˜ํ•ฉ๋‹ˆ๋‹ค.
Linked Issues Check โœ… Passed PR์€ ์—ฐ๊ฒฐ๋œ ์ด์Šˆ #17์˜ ๋ชฉํ‘œ์ธ "์ด์ „ PNG ์•„์ด์ฝ˜์„ SVG๋กœ ๊ต์ฒด"๋ฅผ ์ฝ”๋“œ ์ˆ˜์ค€์—์„œ ์ถฉ์กฑํ•ฉ๋‹ˆ๋‹ค; Image/painterResource๋ฅผ Coil AsyncImage๋กœ ๋ฐ”๊พธ๊ณ  Res.getUri๋ฅผ ํ†ตํ•ด SVG๋ฅผ ๋กœ๋“œํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์œผ๋ฉฐ coil ๊ด€๋ จ ์˜์กด์„ฑ์„ ์ถ”๊ฐ€ํ•ด SVG ๋กœ๋”ฉ์„ ์ง€์›ํ•˜๋Š” ๋ณ€๊ฒฝ์ด ํฌํ•จ๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changes. Docstring coverage check skipped.
โœจ Finishing touches
  • ๐Ÿ“ Generate Docstrings
๐Ÿงช Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between b2b2691 and 8c7595d.

๐Ÿ“’ Files selected for processing (1)
  • composeApp/build.gradle.kts (5 hunks)
๐Ÿšง Files skipped from review as they are similar to previous changes (1)
  • composeApp/build.gradle.kts
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ios-build

Tip

๐Ÿ‘ฎ Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks โ€“ Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks โ€“ Define your own rules using CodeRabbitโ€™s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbitโ€™s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

๐Ÿงน Nitpick comments (1)
composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/HomeScreen.kt (1)

165-172: ์ƒˆ๋กœ๊ณ ์นจ ์•„์ด์ฝ˜์ด AsyncImage๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

์ผ๊ด€์„ฑ ์žˆ๊ฒŒ AsyncImage๋กœ ๋ณ€ํ™˜๋˜์—ˆ๋„ค์š”. ๋‹ค๋งŒ Line 171์˜ ์ฃผ์„ ์ฒ˜๋ฆฌ๋œ ํด๋ฆญ ์ด๋ฒคํŠธ๊ฐ€ ์žˆ๋Š”๋ฐ, ์ด๊ฒƒ๋„ ํ™œ์„ฑํ™”ํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๋งŒ์•ฝ ์ƒˆ๋กœ๊ณ ์นจ ๊ธฐ๋Šฅ์ด ํ•„์š”ํ•˜๋‹ค๋ฉด ์ฃผ์„ ์ฒ˜๋ฆฌ๋œ ํด๋ฆญ ์ด๋ฒคํŠธ๋ฅผ ํ™œ์„ฑํ™”ํ•ด๋ณด์„ธ์š”:

-//                        .clickable(onClick = onNavigateToMyPage)
+                        .clickable(onClick = onRefresh)

๊ทธ๋ฆฌ๊ณ  HomeScreen์˜ ํŒŒ๋ผ๋ฏธํ„ฐ์— onRefresh: () -> Unit์„ ์ถ”๊ฐ€ํ•˜๋ฉด ๋ฉ๋‹ˆ๋‹ค.

๐Ÿ“œ Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 91855de and b2b2691.

โ›” Files ignored due to path filters (14)
  • composeApp/src/commonMain/composeResources/drawable/ic_hamburger.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/ic_profile.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/ic_refresh.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/img_eyes_closed.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/img_eyes_half_closed.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/img_eyes_half_opened.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/drawable/img_eyes_opened.png is excluded by !**/*.png
  • composeApp/src/commonMain/composeResources/files/ic_eyes_closed.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_eyes_half_closed.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_eyes_half_opened.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_eyes_opened.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_hamburger.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_profile.svg is excluded by !**/*.svg
  • composeApp/src/commonMain/composeResources/files/ic_refresh.svg is excluded by !**/*.svg
๐Ÿ“’ Files selected for processing (4)
  • composeApp/build.gradle.kts (1 hunks)
  • composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/HomeScreen.kt (4 hunks)
  • composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/component/PresentMembersItem.kt (3 hunks)
  • gradle/libs.versions.toml (2 hunks)
โฐ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: android-build
๐Ÿ”‡ Additional comments (9)
composeApp/build.gradle.kts (1)

93-97: Coil SVG ์˜์กด์„ฑ ์ถ”๊ฐ€๊ฐ€ ์ž˜ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

Coil 3์—์„œ coil-svg ์•„ํ‹ฐํŒฉํŠธ๋Š” ๋ฉ€ํ‹ฐํ”Œ๋žซํผ์„ ์ง€์›ํ•˜๊ณ , Coil 3๋Š” ์ด์ œ Android, JVM, iOS, macOS, Javascript, WASM์„ ์ง€์›ํ•˜๋Š” Kotlin Multiplatform ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์ž…๋‹ˆ๋‹ค. ์ตœ์‹  ๋ฒ„์ „์ธ 3.3.0์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์–ด ์ข‹๋„ค์š”.

๋„คํŠธ์›Œํ‚น ์˜์กด์„ฑ๋„ ์ ์ ˆํ•˜๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ๊ณ , commonMain์— ์œ„์น˜์‹œ์ผœ ๋ชจ๋“  ํ”Œ๋žซํผ์—์„œ SVG๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ตฌ์„ฑ์ด ์ž˜ ๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค.

gradle/libs.versions.toml (2)

12-12: Coil SVG ๋ฒ„์ „ ์„ค์ •์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค

ํ˜„์žฌ ์ตœ์‹  ๋ฒ„์ „์ธ 3.3.0์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์–ด ์ข‹์Šต๋‹ˆ๋‹ค.


25-28: ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์„ ์–ธ์ด ๊น”๋”ํ•˜๊ฒŒ ์ •๋ฆฌ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

ํ•„์š”ํ•œ Coil ๋ชจ๋“ˆ๋“ค์ด ๋ชจ๋‘ ํฌํ•จ๋˜์–ด ์žˆ๊ณ , ๋ฒ„์ „ ์ฐธ์กฐ๋ฅผ ํ†ตํ•ด ์ผ๊ด€์„ฑ ์žˆ๊ฒŒ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/HomeScreen.kt (3)

43-43: AsyncImage import๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค

Coil 3์˜ coil3.compose.AsyncImage๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์˜ฌ๋ฐ”๋ฅธ ์ ‘๊ทผ์ž…๋‹ˆ๋‹ค.


118-129: ํ–„๋ฒ„๊ฑฐ ๋ฉ”๋‰ด ์•„์ด์ฝ˜์ด AsyncImage๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

PNG์—์„œ SVG๋กœ ๋ณ€ํ™˜ํ•˜๋Š” ๋ชฉํ‘œ์— ๋งž๊ฒŒ ์ž˜ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. Res.getUri("files/ic_hamburger.svg") ์‚ฌ์šฉ๋ฒ•์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค.


131-138: ํ”„๋กœํ•„ ์•„์ด์ฝ˜์ด AsyncImage๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

๋งˆ์ฐฌ๊ฐ€์ง€๋กœ SVG๋กœ ์ž˜ ๋ณ€ํ™˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

composeApp/src/commonMain/kotlin/org/whosin/client/presentation/home/component/PresentMembersItem.kt (3)

23-23: AsyncImage import๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค

coil3.compose.AsyncImage๋ฅผ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ importํ–ˆ์Šต๋‹ˆ๋‹ค.


34-40: ํ”„๋กœํ•„ ์ด๋ฏธ์ง€๋“ค์ด SVG ๊ฒฝ๋กœ๋กœ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

PNG ๋ฆฌ์†Œ์Šค์—์„œ SVG ํŒŒ์ผ ๊ฒฝ๋กœ๋กœ ์ž˜ ๋ณ€ํ™˜๋˜์—ˆ์Šต๋‹ˆ๋‹ค. "files/" prefix๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์ผ๊ด€๋œ ํŒจํ„ด์ด๋„ค์š”.


73-77: AsyncImage๋กœ ์ด๋ฏธ์ง€ ๋กœ๋”ฉ์ด ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค

Res.getUri(imageRes)๋ฅผ ํ†ตํ•ด ๋žœ๋ค ์„ ํƒ๋œ SVG ์ด๋ฏธ์ง€๋ฅผ ๋กœ๋”ฉํ•˜๋„๋ก ์ž˜ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. SVG์˜ ๋ฒกํ„ฐ ํŠน์„ฑ์ƒ ๋†’์ด๋งŒ ์ง€์ •ํ•ด๋„ ๋น„์œจ์ด ์œ ์ง€๋˜์–ด ์ข‹์Šต๋‹ˆ๋‹ค.

@Nico1eKim Nico1eKim merged commit 4af251c into WhosInRoom:develop Sep 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OK Merge ์™„๋ฃŒ๋œ PR REFACTOR ๊ธฐ๋Šฅ์„ ๊ฑด๋“œ๋ฆฌ์ง€ ์•Š๋Š” ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] svg ์ ์šฉํ•˜๊ธฐ

1 participant