Report MTU scan progress while the scan runs - #3
Closed
TaJirax wants to merge 1 commit into
Closed
Conversation
The MTU scan is the longest phase of a connect but emitted no WD_PROGRESS, so a client watching the machine output saw the bar sit at the starting percent and then jump to selecting, with no resolver counts in between. logMTUProgress reports completed, total, valid and rejected across the 10-80 percent band, throttled to one line per percent step. It is deferred from runConnectionMTUTest ahead of the panic recovery, so every exit path reports after the counters have been updated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #4, which merged this commit as part of the full engine sync. The MTU scan progress reporting is on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
logMTUProgress, which reportscompleted,total,valid, andrejectedasWD_PROGRESS phase=mtuacross the 10-80 percent banddeferinrunConnectionMTUTest, registered ahead of the panic recovery so every exit path reports after the counters have been updatedWhy
The MTU scan is the longest phase of a connect, and it emitted no
WD_PROGRESSat all. A client watching the machine output saw the bar sit at thestartingpercent and then jump toselectingwhen the scan finished, with no resolver counts in between. The WhiteDNS desktop app draws its connection progress bar and its scan resolver counts from exactly these fields, so both were frozen for the whole scan.Validation
LOG_LEVEL=WARN, where the human-readable per-resolver lines are suppressed, and the throttle behaviour including the final linego build ./...,go vet ./..., andgo test ./...pass🤖 Generated with Claude Code