-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitmodules #102
base: master
Are you sure you want to change the base?
Update .gitmodules #102
Conversation
Updated to use https, don't have access via ssh. ```Please make sure you have the correct access rights and the repository exists. fatal: clone of '[email protected]:switchbrew/libnx.git' into submodule path '/c/nx-sd/components/EdiZon/libs/libnx' failed Failed to clone 'libs/libnx'. Retry scheduled Cloning into '/c/nx-sd/components/EdiZon/libs/libnx'... Permission denied (publickey). fatal: Could not read from remote repository.```
I don't get how that even matters for devs. That subrepo is for the CI and I doubt you have LIBNX defined to be in that directory. |
It just get's passed over when I compile myself, but I have my scripts setup to compile a lot of things so I have Just seemed more user friendly to have it use https since CI doesn't benefit from it being ssh either. |
Having it be HTTPS would be easier when the make file is updated to make use of the submodule libnx as it doesn’t require people to generate and add an SSH key to their account. |
Looks like TRAVIS even has issues with the git user, that would remove the need for that little sed hack in there as well. |
In my opinion git should be used with SSH instead of HTTPS. But in the first place, @WerWolv should decide what he is using on daily basis. It can be pretty annoying to enter the HTTPS password for a single repo, if you're using ssh-agent for all other repositories. |
No need for any sort of security there, it's pulling a public repo in. |
I'm talking about generally usage. |
For me it really doesn't matter. As it is right now, the submodule isn't used even used by travis properly. Also in the rewrite this submodule will be removed as well |
Updated to use https, don't have access via ssh.