Remove mockup storage and inline styles from web componenets todoMVC #521
+1,396
−342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@camillobruni @rniwa @bgrins Can I have some eyes in this code? If the group is ok with the changes, I'll remove the old versions and publish a clean PR with the updated version. |
lpardosixtosMs
force-pushed
the
lpardosixtos/SimplifyWCTodoMVC
branch
from
537b1a2 to
7ef1756
Compare
|
@bgrins @camillobruni @rniwa this PR is rebased and ready for review. |
| @@ -0,0 +1,1201 @@ | |||
| import { BenchmarkTestStep } from "./benchmark-runner.mjs"; | |||
There was a problem hiding this comment.
I think this was accidentally added no? changes should be default-tests.mjs
|
On the high-level this looks good, I'm no frameworks expert here so I have to defer to @flashdesignory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 main changes:
Results:
Comparison of sync and async steps: