Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TodoMVC - React - add id to input #428

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

flashdesignory
Copy link
Contributor

@flashdesignory flashdesignory commented Sep 1, 2024

This adds an id to the toggle all input - see: tastejs/todomvc#2257

@kara

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but:

  • the same issue exists in the workload for react-redux and preact, can you please fix them as well?
  • the "complex" versions of these workloads need to be rebuilt as well

Thanks!

@flashdesignory
Copy link
Contributor Author

looks good to me, but:

* the same issue exists in the workload for react-redux and preact, can you please fix them as well?

* the "complex" versions of these workloads need to be rebuilt as well

Thanks!

Oh thanks for taking a look at the other ones.
I'll fix those too and rebuild the complex versions

@flashdesignory
Copy link
Contributor Author

numbers just in case:

React

browser before after
chrome 30.57 31.85
firefox 31.47 31.83
safari 31.67 32.20

React-Redux

browser before after
chrome 33.04 32.85
firefox 36.23 36.13
safari 36.67 33.83

Preact

browser before after
chrome 10.58 10.74
firefox 10.67 11.53
safari 12.20 10.77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants