-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News Site Nuxt #427
base: main
Are you sure you want to change the base?
News Site Nuxt #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
similarly to the other PR, I believe you can use article.id
in Section.vue
(instead of concatenating the section id and index
).
import { content as contentEn } from "~/data/en/content"; | ||
import { content as contentJp } from "~/data/jp/content"; | ||
import { content as contentAr } from "~/data/ar/content"; | ||
import { content as contentEn } from "@/data/en/content"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why have you changed this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like nuxt supports both ways and this is consistent with next.js.
At least it still worked after I copied and pasted it by accident 🤣
I can revert that change though if there are concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any doc about that except from a babel plugin that I don't think we're using... Whatever works works also for me here
Do we have before/after numbers? |
I checked just Firefox on my computer, couldn't see any difference. |
Here's a snapshot:
|
@rniwa - any concerns to merge this? |
@rniwa - I did some testing with @camillobruni and here are our crossbench results: current workload:
pr workload:
|
This fixes next.js issue for Nuxt: #422
The fix here is to add unique ids to any article content that is a list.
This is done in the actual data files, so no need for the app to generate them at any point.
@kara