-
Notifications
You must be signed in to change notification settings - Fork 90
Use more helper runner helper methods #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
camillobruni
merged 12 commits into
WebKit:main
from
camillobruni:2024-08-22_runner_refactor
Sep 30, 2024
Merged
Use more helper runner helper methods #421
camillobruni
merged 12 commits into
WebKit:main
from
camillobruni:2024-08-22_runner_refactor
Sep 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
approved these changes
Aug 22, 2024
julienw
reviewed
Aug 26, 2024
rniwa
reviewed
Sep 18, 2024
rniwa
approved these changes
Sep 18, 2024
julienw
reviewed
Sep 30, 2024
julienw
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the new tests!
Co-authored-by: Julien Wajsberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the runner a bit to be more flexible for upcoming experimental PRs.