-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prettier, change print width to 120, and enable dangling commas for functions #371
base: main
Are you sure you want to change the base?
Conversation
At this point, I'd rather not take a huge PR like this into the repo right before the release even if it should not have any real impact on performance in theory. |
Adding v3.1 label to match the label on #370 |
fully agreed, this was definitely meant for after the release. Thanks for adding the label. |
ec73337
to
231c0d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loooking good. I guess we can redo the formatting now that we've released?
yeah, I was waiting to see if there was some interest before doing more work :-) |
I'd definitely prefer some width-limit, especially for the html files. |
231c0d7
to
c6b86de
Compare
Fixes #370
I didn't regenerate all workloads (yet). Please do not land this just yet, this PR is here so that we can decide about #370.
I made separate commits so that we can easily see the effect of each action: