Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newer versions from v1.1 release branch #58

Open
wants to merge 1 commit into
base: motionmark-release-1.1
Choose a base branch
from

Conversation

camillobruni
Copy link

No description provided.

@smfr
Copy link
Contributor

smfr commented Sep 14, 2024

This looks like a mistake?

@smfr smfr closed this Sep 14, 2024
@camillobruni
Copy link
Author

This is very intentional :).

You seem to have multiple versions per release branch which is quite unusal (see speedometer for instance).
This makes local checkouts and running more cumbersome than necessary (it's much easier to have the same path for all versions).

@camillobruni
Copy link
Author

I'm not sure what the policy is here, but I'm mostly used to other projects (and this case specifically Speedometer) that don't use the mono-repo approach and have a single branch / tag per version. If this is a very intentional decision on the Motionmark side I'm all in to update all our tooling to deal with this.

@smfr
Copy link
Contributor

smfr commented Sep 16, 2024

Got it; you should have provided details in the opening comment.

I agree it's confusing that these older release branches have other versions in them, but please provide a PR with a useful commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants