Support WebXR in a self-contained way #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the main harness to pass through a frame object where extant, Update the main harness to use an internally-stored `requestAnimationFrame` to be rerouted in the case of webXR tests, Add the webXR capabilities to the base webGL test
This reverts commit f8393f1.
Use the test itself to change the containing Benchmark's functionality to use the XRSession's requestAnimationFrame and to shuttle through the frame information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of WebXR's history as targeting a separate display device (in the case of a desktop computer connected to an HMD), it requires a separate
requestAnimationFramehandler to manage the frame rate - even in modern, standalone webXR devices. This update localizes the changes required towebgl.jsby dynamically patching the containing Benchmark instance, and adding only the additional parameters required to do the current webGL tests within webXR.