Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JS class syntax in harness code #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Aug 18, 2023

Convert the harness code (and a bit of test code) to use JS class syntax, replacing Utilities.createClass() and Utilities.createSubclass with class and extend, fixing the formatting as appropriate.

Mostly mechanical, other than passing window.location to Utilities.parseParameters so it doesn't depend on the current window object, and fixing a this access in calculateScore().

Some of these classes, like Point, are used in test code, so this may have some impact on test score.

Convert the harness code (and a bit of test code) to use JS class syntax, replacing
`Utilities.createClass()` and `Utilities.createSubclass` with `class` and `extend`,
fixing the formatting as appropriate.

Mostly mechanical, other than passing `window.location` to `Utilities.parseParameters`
so it doesn't depend on the current window object, and fixing a `this` access
in `calculateScore()`.

Some of these classes, like `Point`, are used in test code, so this may have some
impact on test score.
@smfr smfr added the non-trivial This is a "non-trivial" change per the Governance rules label Aug 18, 2023
@smfr
Copy link
Contributor Author

smfr commented Aug 18, 2023

Marked "non-trivial" since the changes touch test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-trivial This is a "non-trivial" change per the Governance rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants