Add three.js benchmark #75
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
threejs/benchmark.js
Outdated
|
|
||
| // Initialize particles | ||
| const particles = []; | ||
| for(let i = 0; i < NUM_PARTICLES; i++) { |
There was a problem hiding this comment.
Could we put this in the init() method?
This might be nice in the future for getting some extra coverage if we add timers.
There was a problem hiding this comment.
I also wouldn't be opposed to having this be part of the first iteration since this seems like the setup a real three.js app would do.
|
Generally LGTM. Would it make sense to bump to the latest threejs version as well? |
kmiller68
left a comment
kmiller68
left a comment
There was a problem hiding this comment.
Overall looks good to me too but it needs to have a tag that runs by default. Maybe we should add a "Frameworks" tag? I'm ok with doing that in a follow up but I assume wasn't what you intended.
threejs/benchmark.js
Outdated
|
|
||
| // Initialize particles | ||
| const particles = []; | ||
| for(let i = 0; i < NUM_PARTICLES; i++) { |
There was a problem hiding this comment.
I also wouldn't be opposed to having this be part of the first iteration since this seems like the setup a real three.js app would do.
|
I added the "Default" tag, updated to the latest version of three.js, and called the initialization as part of the first iteration. |
3 participants
No description provided.