Skip to content

fewer shell warnings #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fewer shell warnings #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25b1cf0
fewer console warnings
camillobruni Oct 30, 2025
1897b33
Merge branch 'main' into 2025-10-30_no-console-warning
camillobruni Oct 30, 2025
bc85569
fix variable name
camillobruni Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion JetStreamDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const measureTotalTimeAsSubtest = false; // Once we move to preloading all resou
const defaultIterationCount = 120;
const defaultWorstCaseCount = 4;

if (!JetStreamParams.prefetchResources)
if (!JetStreamParams.prefetchResources && isInBrowser)
console.warn("Disabling resource prefetching! All compressed files must have been decompressed using `npm run decompress`");

if (!isInBrowser && JetStreamParams.prefetchResources) {
Expand Down
4 changes: 0 additions & 4 deletions cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,6 @@ load("./utils/params.js");


async function runJetStream() {
if (!JetStreamParams.isDefault) {
const paramsDiff = JetStreamParams.nonDefaultParams;
console.warn(`Using non standard params: ${JSON.stringify(paramsDiff, null, 2)}`)
}
try {
await JetStream.initialize();
await JetStream.start();
Expand Down
4 changes: 3 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@
function showNonDefaultParams() {
document.body.classList.add("nonDefaultParams");
const body = document.querySelector("#non-standard-params-table tbody");
for (const [key, value] of Object.entries(JetStreamParams.nonDefaultParams)) {
const nonDefaultParams = JetStreamParams.nonDefaultParams;
console.warn(`Using non standard params: ${JSON.stringify(nonDefaultParams, null, 2)}`)
for (const [key, value] of Object.entries(nonDefaultParams)) {
const defaultValue = DefaultJetStreamParams[key]
const row = body.insertRow();
row.insertCell().textContent = key;
Expand Down
Loading