Skip to content

Black box security location bug#1223

Merged
arcuri82 merged 4 commits intomasterfrom
blackbox-security-bug
Apr 21, 2025
Merged

Black box security location bug#1223
arcuri82 merged 4 commits intomasterfrom
blackbox-security-bug

Conversation

@omursahin
Copy link
Copy Markdown
Collaborator

No description provided.

@omursahin omursahin requested a review from arcuri82 April 15, 2025 10:45
1000
) { args: MutableList<String> ->

args.add("--blackBox")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use setOption(...). we still have plenty of places where we have args.add(. those should be avoided in new tests

args.add("--configPath")
args.add("src/main/resources/config/securitylogin.yaml")

val solution = initAndRun(args)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failure is expected, as you are doing black-box testing. in BB, the state is not reset. so, usually in E2E involving BB we do not write them involving state.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have no specific assertion here. add comment stating this E2E was created to reproduce a bug, and we make sure here that EM does not crash when running this E2E

@omursahin omursahin changed the title Black box security minimization bug Black box security location bug Apr 20, 2025
@omursahin omursahin requested a review from arcuri82 April 20, 2025 19:23
args.add("--configPath")
args.add("src/main/resources/config/securitylogin.yaml")

val solution = initAndRun(args)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have no specific assertion here. add comment stating this E2E was created to reproduce a bug, and we make sure here that EM does not crash when running this E2E

@arcuri82 arcuri82 merged commit aa232fb into master Apr 21, 2025
14 checks passed
@arcuri82 arcuri82 deleted the blackbox-security-bug branch April 13, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants