Skip to content

Modify spec to use Promise.resolve on result of call to suspending function. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgmccabe merged 4 commits into from
Jan 27, 2025
Merged

Modify spec to use Promise.resolve on result of call to suspending function. #57

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46d641b
Modify spec to use Promise.resolve on result of call to suspending fu…
fgmccabe Dec 11, 2024
e72cdc0
Update index.bs
fgmccabe Jan 27, 2025
7154a97
Merge branch 'main' into resolve
fgmccabe Jan 27, 2025
470c8f2
Update index.bs
fgmccabe Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions document/js-api/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ urlPrefix: https://tc39.github.io/ecma262/; spec: ECMASCRIPT
text: PromiseCapabilityRecord; url: sec-promisecapability-records
text: EvaluateCall; url: sec-evaluatecall
text: ExecutionContext; url: sec-execution-contexts
text: IsPromise; url: sec-ispromise
text: Promise; url: sec-promise-constructor
text: PromiseResolve; url: sec-promise-resolve
text: PerformPromiseThen; url: sec-performpromisethen
text: Execution Context Stack; url: execution-context-stack
type: dfn
Expand Down Expand Up @@ -1488,20 +1489,24 @@ To <dfn>create a suspending function</dfn> from a JavaScript function |func|, wi
1. If |ret|.\[[Type]] is <emu-const>throw</emu-const>, then:
1. Let |type|, |payload| and |opaqueData| be the result of [=coerce a JavaScript exception|coercing the JavaScript exception=] |ret|.\[[Value]].
1. [=WebAssembly/Throw=] with |type|, |payload| and |opaqueData|.
1. Otherwise, if [=list/size=] of |ret| is 1 and [$IsPromise$](|ret|.\[[Value]][0]):
1. Let |promise| be |ret|.\[[Value]][0].
1. Set the entry for |async_context| in |map| to [=paused=].
1. Let |awaitResult| be the result of performing [$Completion$]([$Await$](|promise|)).
1. Note: We only invoke [$Await$] if the call to |func| has returned a Promise object.
1. Note: This will suspend both this algorithm, and the WebAssembly function being invoked by the [=evaluate a Promising function=] algorithm. On return, |ret| will be either a normal completion or a throw completion.
1. If the entry for |async_context| in |map| is not [=paused=] then:
1. Perform [=throw a JavaScript exception=] with a {{SuspendError}}.
1. Otherwise, set the entry to [=active=].
1. If |awaitResult|.\[[Type]] is <emu-const>throw</emu-const>, then:
1. Let |type|, |payload| and |opaqueData| be the result of [=coerce a JavaScript exception|coercing the JavaScript exception=] |ret|.\[[Value]].
1. [=WebAssembly/Throw=] with |type|, |payload| and |opaqueData|.
1. Otherwise, return the result of performing [=coerce a JavaScript return=] on |resultTypes| and |awaitResult|.
1. Otherwise, return the result of performing [=coerce a JavaScript return=] on |resultTypes| and |ret|.
1. Otherwise,
1. Let |prRet| be the result of [$PromiseResolve$]({{%Promise%}},|ret|.\[[Value]]).
1. Assert: |prRet|.\[[Type]] is <emu-const>throw</emu-const> or <emu-const>normal</emu-const>.
1. If |prRet|.\[[Type]] is <emu-const>throw</emu-const>, then:
1. Let |type|, |payload| and |opaqueData| be the result of [=coerce a JavaScript exception|coercing the JavaScript exception=] |ret|.\[[Value]].
1. [=WebAssembly/Throw=] with |type|, |payload| and |opaqueData|.
1. Otherwise,
1. Let |promise| be |prRet|.\[[Value]].
1. Set the entry for |async_context| in |map| to [=paused=].
1. Let |awaitResult| be the result of performing [$Completion$]([$Await$](|promise|)).
1. Note: This will suspend both this algorithm, and the WebAssembly function being invoked by the [=evaluate a Promising function=] algorithm. On return, |ret| will be either a normal completion or a throw completion.
1. If the entry for |async_context| in |map| is not [=paused=] then:
1. Perform [=throw a JavaScript exception=] with a {{SuspendError}}.
1. Otherwise, set the entry to [=active=].
1. If |awaitResult|.\[[Type]] is <emu-const>throw</emu-const>, then:
1. Let |type|, |payload| and |opaqueData| be the result of [=coerce a JavaScript exception|coercing the JavaScript exception=] |ret|.\[[Value]].
1. [=WebAssembly/Throw=] with |type|, |payload| and |opaqueData|.
1. Otherwise, return the result of performing [=coerce a JavaScript return=] on |resultTypes| and |awaitResult|.
1. Let |store| be the [=surrounding agent=]'s [=associated store=].
1. Let (|store|, |funcaddr|) be [=func_alloc=](|store|, |functype|, |hostfunc|).
1. Set the [=surrounding agent=]'s [=associated store=] to |store|.
Expand Down
Loading