[Code Annotations] Start Branch Hinting support, in the text format, for Breaks #7567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
May 2, 2025
src/parser/contexts.h
Outdated
| return std::nullopt; | ||
| } | ||
|
|
||
| return bool((*str)[0]); |
There was a problem hiding this comment.
Let's validate that the byte is a 0 or 1 as well.
src/passes/Print.cpp
Outdated
| @@ -2698,6 +2701,18 @@ void PrintSExpression::printDebugLocation(Expression* curr) { | |||
| doIndent(o, indent); | |||
| } | |||
| } | |||
|
|
|||
| auto iter2 = currFunction->codeAnnotations.find(curr); | |||
There was a problem hiding this comment.
Can we rename the iterators locIter and annotIter or similar? Alternatively, we could limit the scope of the iter variables by using if (auto iter = ...; iter != ...) { }.
Co-authored-by: Thomas Lively <[email protected]>
tlively
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first minimal amount of work for Branch Hinting (and
code annotations, more generally): Just the text format, and just a
single instruction (Break).
This design follows debug info: Assuming most instructions have no
branch hints (like most do not have debug info), we do not add a field
to the Break class itself, but to metadata on the side.