comleted assignment #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bansenauer-Cascadia
left a comment
Bansenauer-Cascadia
left a comment
There was a problem hiding this comment.
A good start on the Service logic, but missing the other situation, when the spin is a losing spin.
| return .1; | ||
| double wins = spinRepository.GetSpins() | ||
| .Count(w => w.IsWinning == true); | ||
| return (wins + 1) / (spinRepository.GetCount() + 1); |
Contributor
There was a problem hiding this comment.
This assumption in line 25 is that the spin ALWAYS wins. While this is acceptable in our unit test code where we can handle each case (win or lose) with a different test, our service code has manage both.
Line 25 needs to find some way to check if the current spin is a winner.
| double wins = 4 + 1, count = SpinListData.GetCount() + 1; | ||
| double expected = wins / count; | ||
| Assert.Equal(expected, result); | ||
| } |
Contributor
There was a problem hiding this comment.
Also include the test for
public void SpinService_CalculateAvgWins_LosingSpin() { /* mostly the same code as above, but different expected value */ }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.