Open
Conversation
Contributor
Bansenauer-Cascadia
left a comment
Bansenauer-Cascadia
left a comment
There was a problem hiding this comment.
Great work on the using the test to build code logic. Bonus is complete
Comment on lines
+35
to
+43
| double wins; | ||
| if (isWinning) | ||
| { | ||
| wins = 4 + 1; | ||
| } | ||
| else | ||
| { | ||
| wins = 4; | ||
| } |
Contributor
There was a problem hiding this comment.
Consider using the ternary conditional operator ?: to assign the wins value - it takes a boolean and returns either the first value, if true or second value if not. So the 9 lines above end up as...
double wins = isWinning ? 5 : 4;
| { | ||
| //TODO: Write logic to use the "real" spinRepository NOT the test data | ||
| return .1; | ||
| double wins = spinRepository.GetSpins().Count(s => s.IsWinning) + (IsWinning ? 1 : 0); |
Contributor
There was a problem hiding this comment.
Nice work on this
| { | ||
| [Fact] //BONUS: Refactor into a Theory that tests both a winning and losing spin | ||
| public void SpinService_CalculateAvgWins_WinningSpin() | ||
| [Theory] //BONUS: Refactor into a Theory that tests both a winning and losing spin |
Contributor
There was a problem hiding this comment.
Good work refactoring the Test to consider both cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.