feat(contract): pool validations + multisig emergency cancel (#1119, #1122, #1130, #1131)

[Divine-designs]

Summary

Four contract-safety / hardening enhancements in one PR, all touching contracts/predifi-contract/.

Issue #1122 — Validate outcome descriptions bounds on creation

• New constants MAX_OUTCOME_DESCRIPTION_LEN = 128 and MIN_OUTCOME_DESCRIPTION_LEN = 1.
• validate_pool_invariants panics on empty or oversized outcome labels.
• New typed errors OutcomeDescriptionTooLong = 130, OutcomeDescriptionEmpty = 131.

Issue #1130 — Validate staking deadlines are in the future

• create_pool raises PredifiError::DeadlineInPast = 132 when end_time < current_time (typed, machine-checkable) or when a non-zero start_time is strictly in the past.
• The legacy assert!(end_time > current_time, ...) is preserved as a boundary diagnostic for end_time == current_time.
• start_time == 0 remains the "open immediately" sentinel.

Issue #1131 — Add initial liquidity safety margin checks

• New constant INITIAL_LIQUIDITY_SAFETY_MARGIN_BPS = 100 (1%).
• When max_total_stake > 0, initial_liquidity must be ≥ max_total_stake * 1%; otherwise InitialLiquidityBelowSafetyMargin = 133 is raised. Skipped entirely when max_total_stake == 0 (uncapped pool).

Issue #1119 — Support multi-sig emergency cancellation

• New entry point emergency_cancel_pool(approver, pool_id, reason) and read-only get_emergency_cancel_approvals(pool_id) -> Vec<Address>.
• Threshold EMERGENCY_CANCEL_MULTISIG_THRESHOLD = 2 distinct admin/operator approvals. First approval records intent + reason; subsequent distinct approvals are added; once threshold is met the pool transitions to Canceled via the same path as cancel_pool.
• Same-address re-approval → EmergencyCancelAlreadyApproved = 135. Non-privileged caller → Unauthorized = 10.
• New DataKey variants EmergencyCancelApprovers(pool_id) and EmergencyCancelReason(pool_id), both cleared on execution.

Baseline-fix included

main did not compile in test mode on entry:

• lib.rs referenced ClaimWindowUpdateEvent without importing it (recently moved into events mod).
• lib.rs referenced PredifiError::TimeConstraintError which did not exist on the local enum.

The PR re-exports events into the lib module (pub use events::*;) and adds the missing TimeConstraintError = 84 variant so both cargo build --release --target wasm32-unknown-unknown and cargo test --lib now succeed.

Tests

• 13 new tests at the bottom of test.rs, one block per issue:
  • feat(contract): validate outcome descriptions bounds on creation #1122: too-long rejected, empty rejected, within-bounds accepted
  • feat(contract): validate staking deadlines are in the future #1130: end-time-past rejected, start-time-past rejected, zero sentinel accepted
  • feat(contract): add initial liquidity safety margin checks #1131: below-margin rejected, at-margin accepted, no-cap skips check
  • feat(contract): support multi-sig emergency cancellation #1119: single approval keeps Active, second approval cancels, double-approval rejected, unprivileged rejected
• 1 existing test updated (test_pool_end_time_at_leap_day_already_past) to expect the typed #132 error instead of the legacy assert string.

Verification

cd contract
cargo build --release --target wasm32-unknown-unknown -p predifi-contract   # ✅
cargo test -p predifi-contract --lib                                         # ✅ 386 passed, 0 failed

Closes #1119
Closes #1122
Closes #1130
Closes #1131

[vercel]

@Divine-designs is attempting to deploy a commit to the shola's projects Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@Divine-designs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[Yunusabdul38]

LGTM
Thanks for your contribution