Skip to content

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Oct 24, 2024

Motivation and Context

Jira Link:

Description

mpc-corekit-rn webview solana example

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpc-core-kit-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-angular-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-bitcoin ❌ Failed (Inspect) Feb 4, 2025 5:13am
mpc-core-kit-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-solana ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
mpc-core-kit-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-angular-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-nextjs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-react-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-vanillajs-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-vue-quick-start ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-aggregate-verifier-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-auth0-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-bitcoin-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-farcaster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-google-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-nextauth-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-passwordless-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-ton-telegram-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
sfa-web-ton-telegram-server ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am
web3auth-core-kit-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 5:13am

@AyushBherwani1998
Copy link
Member

Issues:

  • After enableMFA sometimes the login gives setMetadata errored Load failed
  • Create Factor also sometimes gives the setMetadata errored Load Failed
  • EnableMFA doesn't delete hashed factor

@shahbaz17
Copy link
Member

Login works, and all function works too.

  • It's just that when MFA is already enabled and clicked on enable MFA button, it creates a new factor, checked with the Key Details button.
    Rather, it should say, that MFA is already enabled, and no factors should be created.

cc @ieow

@yashovardhan
Copy link
Member

Closing since all changes have been incorporated in the examples in #711

@ieow
Copy link
Contributor Author

ieow commented Jan 27, 2025

Please re-review the changes, as it added expo-router and added offnetwork recovery flow

@ieow ieow reopened this Jan 27, 2025
@shahbaz17 shahbaz17 marked this pull request as draft March 24, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants