Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo & redo support #4863

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

undo & redo support #4863

wants to merge 90 commits into from

Conversation

emptyrivers
Copy link
Contributor

if you want to test it out, checkout this branch, or download the build artifact, either should have the feature automatically enabled. This feature is (for now) disabled by default on alpha/beta/release builds, though you can enable it via the command /wa ff undo - this will persist thru a reload

currently implemented:

  • url on information tab
  • most of the action tab
  • most of the group tab
  • most non-position properties on display tab

there's still a lot to do, especially for custom options & condition options
image
(there's other changes to be made undo-able not caught by that grep)

@emptyrivers emptyrivers added 🎨 Enhancement This pull request implements a new feature. 👩‍🔬 Work in Progress This pull request is still being actively developed and shouldn't be merged. labels Feb 8, 2024
@emptyrivers
Copy link
Contributor Author

note that this is downstream of #4844, so I might close that pull request & just fold it into this one

@Stanzilla
Copy link
Contributor

note that this is downstream of #4844, so I might close that pull request & just fold it into this one

I think keeping it separate makes more sense, we just need to review the FF PR properly and test it, I haven't done that so far

@InfusOnWoW
Copy link
Contributor

Yeah, please keep them separate.

@emptyrivers
Copy link
Contributor Author

emptyrivers commented Apr 4, 2024 •
edited
Loading

an update on progess:

majority of controls in WA options now perform undo-able actions. exceptions are:

  • some region/subregion options
  • (regular) group options
  • "exotic" things like MoverPicker, or TextEditor (though I imagine most folks who read this won't consider the code editor to be "exotic")
  • Duplicate/Add/Delete/Rename whole auras is not yet supported (delete will also immediately break the history until you reload the UI)

@emptyrivers
Copy link
Contributor Author

(note, this pull has #4982 merged in, for my own sanity. The actual changeset is smaller (though, honestly not that much smaller)

@krazyito65
Copy link
Contributor

Small graphical request: if either the 'undo' or 'redo' is empty (or the last item in the history), have the text 'fade' (optionally unclickable?) to indicate you can't go any further

@emptyrivers emptyrivers force-pushed the undo branch 2 times, most recently from e42f616 to c1d2ff8 Compare April 4, 2024 21:17
@InfusOnWoW InfusOnWoW added the 🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature. label May 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024 •
edited
Loading

An experimental build of WeakAuras with the changes in this pull request is available here.
Build Time: Mon Feb 24 04:23:20 UTC 2025
Commit:

@emptyrivers
add feature flag 'undo'
510cc0e 
functionality related to undo/redo will be hidden behind this feature until it's 'ready' for the LCD user

Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
add some toolbar buttons
e515eda
@emptyrivers
make a debugprint
1e68a9a 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
simple time machine
282ab6b 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
generalize the time machine to any kind of mutation
9ec2aa5 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
force an ordering of time machine records
4036517 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
further tweaks to TimeMachine
57b66b4 
mostly to accomodate how the commonoptions setall works

Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
lets just crib database language fully and make the concept of a tran…
5653f19 
…saction

Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
support undoing changes to action options
00f062b 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
support undo for many options in group & display tab
1664ffd 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
finish supporting information options
7389eff 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
add type hint
f126cbe 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
dry run of animation options
d365d55 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
fix a few bugs
cfe67c0 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
wip
fb06b65 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
drop some unnecessary set funcs
e8f51e9 
Signed-off-by: Allen Faure <[email protected]>
@emptyrivers
fix a couple bugs
85b87fd 
Signed-off-by: Allen Faure <[email protected]>
Stanzilla and others added 30 commits February 22, 2025 16:38
@Stanzilla @emptyrivers
Update WeakAurasModelPaths from wago.tools
20f8800
@InfusOnWoW @emptyrivers
Unit Characteristics: Allow "Assigned Role" check for non-group units
b63071a 
As it is occasionally useful to do this.
@InfusOnWoW @emptyrivers
Guard against expirationTime/duration being strings in various places
09bb15e 
Fixes: WeakAuras#5622
@InfusOnWoW @emptyrivers
Fix Glow/Border anchor_area lua error in Options
985020c 
Fixes: WeakAuras#5635
@InfusOnWoW @emptyrivers
Linear Progress Texture: Add an inverse setting
5244e66 
Fixes: WeakAuras#5632
@InfusOnWoW @emptyrivers
CircularProgressTexture: Add inverse option
edc9723
@mrbuds @emptyrivers
classic_era toc update
96af22b
@InfusOnWoW @emptyrivers
Sanity check WeakAuras.ScanEvents event's type
88c1567 
Fixes: WeakAuras#5628
@InfusOnWoW @emptyrivers
Empty Base Region: Add a thumbnail icon
6954d19 
Fixes: WeakAuras#5631
@InfusOnWoW @emptyrivers
Also remove "Clipped Progress" on Classic
2d9e256 
Since the clipping is now also broken on Classic, apply the same change
to classic.

Fixes: WeakAuras#5634
@InfusOnWoW @emptyrivers
Modernize: Fix lua error if there are no authorOptions
6e08bb2 
Fixes: WeakAuras#5641
@InfusOnWoW @emptyrivers
Tweak Changelog display
963e5ad
@InfusOnWoW @emptyrivers
Update Discord List
6eaebb6
@Stanzilla @emptyrivers
Update WeakAurasModelPaths from wago.tools
8f1a99e
@InfusOnWoW @emptyrivers
Update Atlas File List from wago.tools
f8073d4
@dependabot @emptyrivers
Bump cbrgm/mastodon-github-action from 2.1.10 to 2.1.12
e207c2b 
Bumps [cbrgm/mastodon-github-action](https://github.com/cbrgm/mastodon-github-action) from 2.1.10 to 2.1.12.
- [Release notes](https://github.com/cbrgm/mastodon-github-action/releases)
- [Commits](cbrgm/mastodon-github-action@v2.1.10...v2.1.12)

---
updated-dependencies:
- dependency-name: cbrgm/mastodon-github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@its-riece @InfusOnWoW @emptyrivers
Add itemInRange condition support to more Item Triggers (WeakAuras#5639)
9d11c01 
This PR adds the `Item in Range` conditional used by `Cooldown Progress
(Item)` triggers to other item triggers.

Co-authored-by: Infus <[email protected]>
@InfusOnWoW @emptyrivers
Classic Era: Fix Minimize Button
2853b67 
Somehow the TitleContainer ended up in front of the Minimize Container
on classic era (but not on any other variant), and only in the latest
patch.

I have no idea what actually changed, but puting the minimize button
before the title container is probably a good idea on all versions.

Fixes: WeakAuras#5647
@InfusOnWoW @emptyrivers
Fix lua error if a group contains an aura with a texture sub element
cdf91e8 
Fixes: WeakAuras#5653
@InfusOnWoW @emptyrivers
Fix font justify missing after update
3953a64 
If an update changes both the position and the justify setting, then
somehow the justify setting did not get applied.

This is almost certainly a bug in how wow optimizes the text layout,
apparently the text layout is not properly marked as dirty.

Settting the text to an empty string, which is later overriden with the
correct text seems to be enough to force wow to relayout the text

Fixes: WeakAuras#5654
@InfusOnWoW @emptyrivers
Regions\Text.lua: Add types
abc3f1a
@Stanzilla @emptyrivers
Update WeakAurasModelPaths from wago.tools
ef3b124
@emptyrivers
only nag user on /reload or /camp, instead of every loading screen
915a046
@InfusOnWoW @emptyrivers
Update Atlas File List from wago.tools
0a44ddb
@Stanzilla @emptyrivers
Update WeakAurasModelPaths from wago.tools
27fd2c7
@mrbuds @emptyrivers
smoll fix (WeakAuras#5678)
43b6207
@mrbuds @emptyrivers
Update toc files for Cataclysm new patch
7625577
@mrbuds @emptyrivers
Fix integer overflow error with SpellKnow checks
0db8ac2
@emptyrivers
bunch of review comments
9d675de
@emptyrivers
fix a typo
b7cf19d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfusOnWoW InfusOnWoW InfusOnWoW left review comments

@mrbuds mrbuds Awaiting requested review from mrbuds

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🎨 Enhancement This pull request implements a new feature. 🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@emptyrivers @Stanzilla @InfusOnWoW @krazyito65 @nullKomplex @mrbuds @its-riece