Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Added more Frontend projects you can contribute #587

Closed
wants to merge 0 commits into from

Conversation

soumil1
Copy link

@soumil1 soumil1 commented Jul 2, 2023

Fixes Issue

#584

Changes proposed

  • Gatsby
  • Twbs Bootstrap
  • Screenshots

    Note to reviewers

    @soumil1
    Copy link
    Author

    soumil1 commented Jul 2, 2023

    #584 (comment)

    Copy link

    @sergeivassiljev sergeivassiljev left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    looks ok

    @AnuragThePathak
    Copy link
    Contributor

    I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

    @siddhant-khisty
    Copy link
    Contributor

    Hey, @soumil1 it seems you might have edited all the existing resources as well. We are unable to figure out which ones were added by you. Either recreate a branch and re-commit the changes and open a new PR or you can mention the resources which you have added

    @soumil1
    Copy link
    Author

    soumil1 commented Jul 4, 2023

    Hey, @soumil1 it seems you might have edited all the existing resources as well. We are unable to figure out which ones were added by you. Either recreate a branch and re-commit the changes and open a new PR or you can mention the resources which you have added

    Hey, @siddhant-khisty sorry from my end. Actually, on the first line, I mistakenly changed "## - 2nd level heading" to "# - 1st level" on Open Source Frontend projects to which you can contribute, which made it appear as if I had changed the entire Readme, but I haven't. I only added the "Gatsby" and "Twbs Bootstrap" links

    @soumil1
    Copy link
    Author

    soumil1 commented Jul 4, 2023

    I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

    Can I mention the new changes I made to the description now?

    @siddhant-khisty
    Copy link
    Contributor

    I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

    Can I mention the new changes I made to the description now?

    Yes

    @soumil1
    Copy link
    Author

    soumil1 commented Jul 4, 2023

    I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well.

    Can I mention the new changes I made to the description now?

    Yes

    Edited the description. Can you please check

    @siddhant-khisty
    Copy link
    Contributor

    Hey, @soumil1 these projects that you've included do not really fit under the frontend category. Imo they would be better suited as backend projects. Yes they are frontend frameworks, but a contributor would need a good amount of frontend as well as backend knowledge to contribute to them. I could be wrong tho. @AnuragThePathak @kaiwalyakoparkar what are your opinions on this issue?

    @AnuragThePathak
    Copy link
    Contributor

    Bootstrap one is frontend ig and Gatsby too (but these are not web apps, except the Bootstrap website).

    @soumil1
    Copy link
    Author

    soumil1 commented Jul 8, 2023

    So what do I do now? @siddhant-khisty @AnuragThePathak
    Can I create a new pull request and update both of these links in backend development?

    @siddhant-khisty
    Copy link
    Contributor

    @soumil1 The bootstrap is one fine I guess. But please move the gatsby one to backend. You can simply push more commits to this branch to update this PR as well

    Copy link
    Contributor

    @siddhant-khisty siddhant-khisty left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    @siddhant-khisty
    Copy link
    Contributor

    @soumil1 please fix the merge conflicts and we can merge

    @soumil1 soumil1 closed this Jul 8, 2023
    @soumil1 soumil1 force-pushed the frontend-project branch 2 times, most recently from c0e5f20 to 4875661 Compare July 8, 2023 16:14
    @soumil1
    Copy link
    Author

    soumil1 commented Jul 8, 2023

    Sorry for causing a problem. I accidentally force-pushed the commit instead of deleting the conflicts. Is there any way to recover from this disaster :(
    @siddhant-khisty

    @AnuragThePathak
    Copy link
    Contributor

    Do you still have the commits with you? If yes we can recover from the disaster.

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants