-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added more Frontend projects you can contribute #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
I think your commit has some problem, so Git is unable to detect the existing lines properly. It may be helpful if you can add the new stuff in description as well. |
Hey, @soumil1 it seems you might have edited all the existing resources as well. We are unable to figure out which ones were added by you. Either recreate a branch and re-commit the changes and open a new PR or you can mention the resources which you have added |
Hey, @siddhant-khisty sorry from my end. Actually, on the first line, I mistakenly changed "## - 2nd level heading" to "# - 1st level" on Open Source Frontend projects to which you can contribute, which made it appear as if I had changed the entire Readme, but I haven't. I only added the "Gatsby" and "Twbs Bootstrap" links |
Can I mention the new changes I made to the description now? |
Yes |
Edited the description. Can you please check |
Hey, @soumil1 these projects that you've included do not really fit under the frontend category. Imo they would be better suited as backend projects. Yes they are frontend frameworks, but a contributor would need a good amount of frontend as well as backend knowledge to contribute to them. I could be wrong tho. @AnuragThePathak @kaiwalyakoparkar what are your opinions on this issue? |
Bootstrap one is frontend ig and Gatsby too (but these are not web apps, except the Bootstrap website). |
So what do I do now? @siddhant-khisty @AnuragThePathak |
@soumil1 The bootstrap is one fine I guess. But please move the gatsby one to backend. You can simply push more commits to this branch to update this PR as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@soumil1 please fix the merge conflicts and we can merge |
c0e5f20
to
4875661
Compare
Sorry for causing a problem. I accidentally force-pushed the commit instead of deleting the conflicts. Is there any way to recover from this disaster :( |
Do you still have the commits with you? If yes we can recover from the disaster. |
Fixes Issue
#584
Changes proposed
Screenshots
Note to reviewers