Skip to content

Add red dot capability for visualizing the center of compartments #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Apr 29, 2025

Description

This PR adds functionality for CytoDataFrame to display a red dot where the center of a compartment is, relative to the image object crop. I also made some minor adjustments to existing tests to help enable us to check for red or green pixels in output. During testing @jenna-tomkinson noticed that the bounding boxes might not be operating correctly so we raised #92 to help address this in the future (nothing here should change bounding box capabilities).

Closes #77

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review April 29, 2025 16:22
@d33bs d33bs requested a review from jenna-tomkinson April 29, 2025 16:22
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@d33bs
Copy link
Member Author

d33bs commented Apr 29, 2025

Thanks @jenna-tomkinson ! After making some changes based on your comments I'll now merge this in.

@d33bs d33bs merged commit 9541f09 into WayScience:main Apr 29, 2025
9 checks passed
@d33bs d33bs deleted the red-dot branch April 29, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add red dot at center of record object focus to differentiate from other objects
2 participants