feat: added "basic" level gym badge#1004
Conversation
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
Awesome, thank you for the contribution! You didn't have to add all of the locales, as they're generated when merged to main but you saved me some OpenAI credits, so thanks for that! @Petap0w, @ReuschelCGN / @Fabio1988, and @lenisko if you can please provide feedback on your respective human translations though that would be great!
I left one comment in the files changed, but it's nothing major, just code format nitpicking. You'll need to do something similar in the User Profile dialog as well as you currently end up with this:
| " | ||
| />` | ||
| ${ | ||
| badge != '4' |
There was a problem hiding this comment.
Whenever possible I try to do "positive" ternary checks to try and keep it consistent and clearer so let's change this to badge == '4' ? '' : ...etc
|
I would suggest to use a different number, at some point we will have platin badges as well, what then? :) |
| "badge_1": "Bronze", | ||
| "badge_2": "Silber", | ||
| "badge_3": "Gold", | ||
| "badge_4": "Einfach", |
|
Thanks for the comments. I've fixed the profile page and updated the ternary. Can you please point me to the right piece of code for the database migration? |
|
I've added the migration now and fixed the badges in the profile. Hopefully this should be all good now! For the badge icons, I'm using
|
TurtIeSocks
left a comment
TurtIeSocks
left a comment
There was a problem hiding this comment.
Sorry for the delay, this is looking great now!
|
🎉 This PR is included in version 1.33.0-develop.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Something is wrong in profile tab with counters |
What's the issue with it? It looks like the 4 badges in your image are "basic" level gym badges (not Bronze). Were they previously Bronze and the data migration did not work? |
I just added them and they counted as bronze. I also have way less gold and silver ones |
5 participants
This PR adds the gym badge level "basic" (which is the level before Bronze, but still different from "not obtained"). This better matches the options of gym badges in-game.
The changes in file
src/features/gym/gymMarker.jsallows the badge icon to appear with no border, which is how it is displayed in Pogo.Previous gym badges/filters: All, None (badge_0), Bronze (badge_1), Silver (badge_2), Gold (badge_3)
Updated gym badges/filters: All, None (badge_0), Basic (badge_4), Bronze (badge_1), Silver (badge_2), Gold (badge_3)