Skip to content

Commit

Permalink
fix: favicon in dev
Browse files Browse the repository at this point in the history
  • Loading branch information
TurtIeSocks committed Jan 24, 2024
1 parent 8dd94c9 commit 353a7aa
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 16 deletions.
44 changes: 29 additions & 15 deletions packages/vite-plugins/lib/favicon.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,37 @@ const { resolve } = require('path')
const fs = require('fs')

/**
* @param {boolean} isDevelopment
* @returns {import('vite').Plugin}
*/
const faviconPlugin = () => ({
name: 'vite-plugin-locales',
generateBundle() {
const favicon = fs.existsSync(
resolve(__dirname, '../../../public/favicon/favicon.ico'),
)
? resolve(__dirname, '../../../public/favicon/favicon.ico')
: resolve(__dirname, '../../../public/favicon/fallback.ico')
this.emitFile({
type: 'asset',
fileName: 'favicon.ico',
source: fs.readFileSync(favicon),
})
},
})
const faviconPlugin = (isDevelopment) => {
const favicon = fs.existsSync(
resolve(__dirname, '../../../public/favicon/favicon.ico'),
)
? resolve(__dirname, '../../../public/favicon/favicon.ico')
: resolve(__dirname, '../../../public/favicon/fallback.ico')
return {
name: 'vite-plugin-locales',
generateBundle() {
if (isDevelopment) return
this.emitFile({
type: 'asset',
fileName: 'favicon.ico',
source: fs.readFileSync(favicon),
})
},
configureServer(server) {
server.middlewares.use((req, res, next) => {
if (req.url === '/favicon.ico') {
res.writeHead(200, { 'Content-Type': 'image/x-icon' })
res.end(fs.readFileSync(favicon))
return
}
next()
})
},
}
}

module.exports = {
faviconPlugin,
Expand Down
2 changes: 1 addition & 1 deletion vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const viteConfig = defineConfig(({ mode }) => {
]
: []),
localePlugin(isDevelopment),
faviconPlugin(),
faviconPlugin(isDevelopment),
muteWarningsPlugin([
['SOURCEMAP_ERROR', "Can't resolve original location of error"],
]),
Expand Down

0 comments on commit 353a7aa

Please sign in to comment.