Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the boost dependency when building from source. #230

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

q82419
Copy link
Collaborator

@q82419 q82419 commented May 27, 2024

No description provided.

Copy link
Collaborator

alabulei1 commented May 27, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 35f0ab3c93755dd48bbd9434e281a0034f8d5415

Key changes:

  1. The patch removes the libboost-all-dev dependency from the build instructions in linux.md, riscv64.md, and image.md files.
  2. The patch updates the build instructions to reflect that the boost dependency is not needed after WasmEdge 0.13.0.
  3. The patch includes adjustments in both English and Chinese documentation files.

Potential problems:

  1. The patch may cause issues for users trying to build from source who rely on the libboost-all-dev library.
  2. It might be beneficial to explicitly mention in the updated instructions why the boost dependency was removed and if there are any alternative dependencies or changes in the codebase that make boost unnecessary.

@alabulei1 alabulei1 merged commit 433a7f8 into main May 27, 2024
6 checks passed
@alabulei1 alabulei1 deleted the yiying/boost branch May 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants